webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc - Issue 1886783002: Fix bug when the BWE times out due to no incoming packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

Issue 1886783002: Fix bug when the BWE times out due to no incoming packets. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Add dchecks. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

index 8bfb8ed0fd36abb37a74e3c2735cba9478c14539..f04d9e68c09a53527085cc6ef0f32ac769bad704 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_unittest_helper.cc

@@ -583,7 +583,7 @@ void RemoteBitrateEstimatorTest::TestWrappingHelper(

absolute_send_time = AddAbsSendTime(absolute_send_time,

AbsSendTime(silence_time_s, 1));

bitrate_estimator_->Process();

- for (size_t i = 0; i < 10; ++i) {

+ for (size_t i = 0; i < 21; ++i) {

IncomingPacket(kDefaultSsrc, 1000, clock_.TimeInMilliseconds(), timestamp,

absolute_send_time, true);

timestamp += kFrameIntervalMs;