Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1875003004: Fix WebRTC API framework build. (Closed)

Created:
4 years, 8 months ago by tkchin_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix WebRTC API framework build. BUG=webrtc:5737 Committed: https://crrev.com/5209d671f2597e88004ad7acd097294d9460ce7f Cr-Commit-Position: refs/heads/master@{#12391}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Update scripts #

Total comments: 32

Patch Set 3 : CR comments #

Patch Set 4 : Fix header #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+745 lines, -795 lines) Patch
M webrtc/api/objc/RTCAVFoundationVideoSource.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCAudioTrack.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCEAGLVideoView.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCRtpSender.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/objc/RTCVideoTrack.h View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj View 1 12 chunks +395 lines, -375 lines 0 comments Download
M webrtc/build/ios/SDK/Framework/WebRTC/WebRTC.h View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/build/ios/build_ios_framework.sh View 1 2 1 chunk +123 lines, -56 lines 0 comments Download
M webrtc/build/ios/build_ios_libs.sh View 1 2 1 chunk +114 lines, -53 lines 0 comments Download
D webrtc/build/ios/export_headers View 1 1 chunk +0 lines, -95 lines 0 comments Download
A + webrtc/build/ios/export_headers.py View 1 2 4 chunks +26 lines, -16 lines 0 comments Download
D webrtc/build/ios/flatten_ios_headers View 1 1 chunk +0 lines, -46 lines 0 comments Download
A webrtc/build/ios/flatten_ios_headers.py View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
D webrtc/build/ios/merge_ios_libs View 1 1 chunk +0 lines, -121 lines 0 comments Download
A + webrtc/build/ios/merge_ios_libs.py View 1 2 5 chunks +28 lines, -25 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
tkchin_webrtc
4 years, 8 months ago (2016-04-11 19:08:10 UTC) #3
kjellander_webrtc
Drive-by review https://codereview.webrtc.org/1875003004/diff/1/webrtc/build/ios/build_ios_framework.sh File webrtc/build/ios/build_ios_framework.sh (right): https://codereview.webrtc.org/1875003004/diff/1/webrtc/build/ios/build_ios_framework.sh#newcode65 webrtc/build/ios/build_ios_framework.sh:65: if [ $? -ne 0 ]; then ...
4 years, 8 months ago (2016-04-11 20:01:30 UTC) #6
Chuck
lgtm
4 years, 8 months ago (2016-04-12 17:42:07 UTC) #7
tkchin_webrtc
On 2016/04/12 17:42:07, Chuck wrote: > lgtm PTAL I changed the script to be a ...
4 years, 8 months ago (2016-04-15 00:27:10 UTC) #8
kjellander_webrtc
On 2016/04/15 00:27:10, tkchin_webrtc wrote: > On 2016/04/12 17:42:07, Chuck wrote: > > lgtm > ...
4 years, 8 months ago (2016-04-15 04:59:22 UTC) #9
kjellander_webrtc
...and the comments. https://codereview.webrtc.org/1875003004/diff/20001/webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj File webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj (right): https://codereview.webrtc.org/1875003004/diff/20001/webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj#newcode1 webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj:1: // !$*UTF8*$! Ouch, is there a ...
4 years, 8 months ago (2016-04-15 04:59:42 UTC) #10
tkchin_webrtc
https://codereview.webrtc.org/1875003004/diff/20001/webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj File webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj (right): https://codereview.webrtc.org/1875003004/diff/20001/webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj#newcode1 webrtc/build/ios/SDK/Framework/WebRTC.xcodeproj/project.pbxproj:1: // !$*UTF8*$! On 2016/04/15 04:59:41, kjellander (webrtc) wrote: > ...
4 years, 8 months ago (2016-04-16 00:34:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875003004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875003004/80001
4 years, 8 months ago (2016-04-16 02:14:31 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 8 months ago (2016-04-16 04:15:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875003004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875003004/80001
4 years, 8 months ago (2016-04-16 05:37:04 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-16 07:37:40 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1875003004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1875003004/80001
4 years, 8 months ago (2016-04-16 19:03:36 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-16 19:06:38 UTC) #24
commit-bot: I haz the power
4 years, 8 months ago (2016-04-16 19:06:46 UTC) #26
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/5209d671f2597e88004ad7acd097294d9460ce7f
Cr-Commit-Position: refs/heads/master@{#12391}

Powered by Google App Engine
This is Rietveld 408576698