Fix WebRTC API framework build.

webrtc/build/ios/merge_ios_libs.py

 #!/usr/bin/python
 
 #  Copyright 2016 The WebRTC project authors. All Rights Reserved.
 #
 #  Use of this source code is governed by a BSD-style license
 #  that can be found in the LICENSE file in the root of the source
 #  tree. An additional intellectual property rights grant can be found
 #  in the file PATENTS.  All contributing project authors may
 #  be found in the AUTHORS file in the root of the source tree.
 
 """Script for merging generated iOS libraries."""
 
 import optparse
 import os
 import re
 import subprocess
 import sys
 
+# Valid arch subdir names.
+VALID_ARCHS = ['arm_libs', 'arm64_libs', 'ia32_libs', 'x64_libs']
 
 def MergeLibs(lib_base_dir):

[kjellander_webrtc, 2016/04/15 04:59:41]

nit: +1 blank line before top-level definition
https://google.github.io/styleguide/pyguide.html?showone=Blank_Lines#Blank_Lines
Applies to whole file.

[tkchin_webrtc, 2016/04/16 00:34:19]

Done.

   """Merges generated iOS libraries for different archs.
 
   Uses libtool to generate FAT archive files for each generated library.
 
   Args:
     lib_base_dir: directory whose subdirectories are named by architecture and
                   contain the built libraries for that architecture
 
   Returns:
     Exit code of libtool.
   """
-  include_dir_name = 'include'
-  output_dir_name = 'lib'
+  output_dir_name = 'fat_libs'
   archs = [arch for arch in os.listdir(lib_base_dir)
-           if arch[:1] != '.' and arch != output_dir_name
-           and arch != include_dir_name]
+           if arch in VALID_ARCHS]
   # For each arch, find (library name, libary path) for arch. We will merge
   # all libraries with the same name.
   libs = {}
-  for dirpath, _, filenames in os.walk(lib_base_dir):
-    if dirpath.endswith(output_dir_name):
+  for lib_dir in [os.path.join(lib_base_dir, arch) for arch in VALID_ARCHS]:
+    if not os.path.exists(lib_dir):
       continue
-    for filename in filenames:
-      if not filename.endswith('.a'):
-        continue
-      entry = libs.get(filename, [])
-      entry.append(os.path.join(dirpath, filename))
-      libs[filename] = entry
-
+    for dirpath, _, filenames in os.walk(lib_dir):
+      for filename in filenames:
+        if not filename.endswith('.a'):
+          continue
+        entry = libs.get(filename, [])
+        entry.append(os.path.join(dirpath, filename))
+        libs[filename] = entry
   orphaned_libs = {}
   valid_libs = {}
   for library, paths in libs.items():
     if len(paths) < len(archs):
       orphaned_libs[library] = paths
     else:
       valid_libs[library] = paths
   for library, paths in orphaned_libs.items():
     components = library[:-2].split('_')[:-1]
     found = False
     # Find directly matching parent libs by stripping suffix.
     while components and not found:
       parent_library = '_'.join(components) + '.a'
       if parent_library in valid_libs:
         valid_libs[parent_library].extend(paths)
         found = True
         break
       components = components[:-1]
     # Find next best match by finding parent libs with the same prefix.
     if not found:
       base_prefix = library[:-2].split('_')[0]
       for valid_lib, valid_paths in valid_libs.items():
-        prefix = '_'.join(components)
         if valid_lib[:len(base_prefix)] == base_prefix:
           valid_paths.extend(paths)
           found = True
           break
     assert found
 
   # Create output directory.
   output_dir_path = os.path.join(lib_base_dir, output_dir_name)
   if not os.path.exists(output_dir_path):
     os.mkdir(output_dir_path)
 
   # Use this so libtool merged binaries are always the same.
   env = os.environ.copy()
   env['ZERO_AR_DATE'] = '1'
 
   # Ignore certain errors.
   libtool_re = re.compile(r'^.*libtool:.*file: .* has no symbols$')
 
   # Merge libraries using libtool.
+  libtool_returncode = 0
   for library, paths in valid_libs.items():
     cmd_list = ['libtool', '-static', '-v', '-o',
                 os.path.join(output_dir_path, library)] + paths
     libtoolout = subprocess.Popen(cmd_list, stderr=subprocess.PIPE, env=env)
     _, err = libtoolout.communicate()
     for line in err.splitlines():
       if not libtool_re.match(line):
         print >>sys.stderr, line
     # Unconditionally touch the output .a file on the command line if present
     # and the command succeeded. A bit hacky.
-    if not libtoolout.returncode:
+    libtool_returncode = libtoolout.returncode
+    if not libtool_returncode:
       for i in range(len(cmd_list) - 1):
         if cmd_list[i] == '-o' and cmd_list[i+1].endswith('.a'):
           os.utime(cmd_list[i+1], None)
           break
     else:
-      return libtoolout.returncode
-  return libtoolout.returncode
+      return libtool_returncode

[kjellander_webrtc, 2016/04/15 04:59:42]

You can skip this else statement.

[tkchin_webrtc, 2016/04/16 00:34:19]

Done.

+  return libtool_returncode
 
 
 def Main():
   parser = optparse.OptionParser()
   _, args = parser.parse_args()

[kjellander_webrtc, 2016/04/15 04:59:41]

You coulld use https://docs.python.org/2/library/sys.html#sys.argv instead to
save some lines.

[tkchin_webrtc, 2016/04/16 00:34:19]

Done.

   if len(args) != 1:
     parser.error('Error: Exactly 1 argument required.')
   lib_base_dir = args[0]
   MergeLibs(lib_base_dir)
 
 if __name__ == '__main__':
   sys.exit(Main())