Fix WebRTC API framework build.

webrtc/build/ios/flatten_ios_headers.py

 #!/usr/bin/python
 
 #  Copyright 2016 The WebRTC project authors. All Rights Reserved.
 #
 #  Use of this source code is governed by a BSD-style license
 #  that can be found in the LICENSE file in the root of the source
 #  tree. An additional intellectual property rights grant can be found
 #  in the file PATENTS.  All contributing project authors may
 #  be found in the AUTHORS file in the root of the source tree.
 
 """Script for flattening iOS header structure."""
 
 import optparse
 import os
 import shutil
 import sys
 
-def FlattenHeaders(lib_base_dir, framework_base_dir):
+def FlattenHeaders(input_dir, output_dir):

[kjellander_webrtc, 2016/04/15 04:59:41]

nit: +1 blank line before top-level definition
https://google.github.io/styleguide/pyguide.html?showone=Blank_Lines#Blank_Lines
Applies to whole file.

[tkchin_webrtc, 2016/04/16 00:34:19]

Done.

   """Flattens iOS header file directory structure."""
-  include_dir = 'include'
-  unflattened_include_dir_path = os.path.join(lib_base_dir, include_dir)
-  flattened_include_dir_path = os.path.join(framework_base_dir, include_dir)
+  # Create output directories.
+  if not os.path.exists(output_dir):
+    os.mkdir(output_dir)
 
-  # Create output directories.
-  if not os.path.exists(framework_base_dir):
-    os.mkdir(framework_base_dir)
-  if not os.path.exists(flattened_include_dir_path):
-    os.mkdir(flattened_include_dir_path)
-
-  for dirpath, _, filenames in os.walk(unflattened_include_dir_path):
+  for dirpath, _, filenames in os.walk(input_dir):
     for filename in filenames:
       current_path = os.path.join(dirpath, filename)
-      new_path = os.path.join(flattened_include_dir_path, filename)
+      new_path = os.path.join(output_dir, filename)
       shutil.copy(current_path, new_path)
 
 def Main():
   parser = optparse.OptionParser()

[kjellander_webrtc, 2016/04/15 04:59:41]

If you're only using positional arguments you might as well use
https://docs.python.org/2/library/sys.html#sys.argv instead.

[tkchin_webrtc, 2016/04/16 00:34:19]

Done.

   _, args = parser.parse_args()
   if len(args) != 2:
     parser.error('Error: Exactly 2 arguments required.')

[kjellander_webrtc, 2016/04/15 04:59:41]

Output a usage line as well?

[tkchin_webrtc, 2016/04/16 00:34:19]

Used argparse everywhere to get free usage and checking.

-  lib_base_dir = args[0]
-  framework_base_dir = args[1]
-  FlattenHeaders(lib_base_dir, framework_base_dir)
+  input_dir = args[0]
+  output_dir = args[1]
+  FlattenHeaders(input_dir, output_dir)
 
 if __name__ == '__main__':
   sys.exit(Main())