Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 1857153002: Changed AECM to be built using C++ (Closed)

Created:
4 years, 8 months ago by peah-webrtc
Modified:
4 years, 8 months ago
Reviewers:
ivoc, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

What was done was -changed filenames to *.cc -fixed issues with implicit casts causing build errors. All other CL warnings were ignored as the original code is not changed, merely moved. BUG=webrtc:5724 NOPRESUBMIT=true Committed: https://crrev.com/2704512f7b8000e2abec3c18b976d53b07fc244c Cr-Commit-Position: refs/heads/master@{#12307}

Patch Set 1 : Renamed the files #

Patch Set 2 : Fixed build errors #

Patch Set 3 : Removed unused table that caused build error #

Patch Set 4 : Added external declaration to the delay estimator wrapper inclusion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -4473 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 4 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/aecm/aecm_core.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
D webrtc/modules/audio_processing/aecm/aecm_core.c View 1 chunk +0 lines, -1233 lines 0 comments Download
A + webrtc/modules/audio_processing/aecm/aecm_core.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
D webrtc/modules/audio_processing/aecm/aecm_core_c.c View 1 chunk +0 lines, -771 lines 0 comments Download
A + webrtc/modules/audio_processing/aecm/aecm_core_c.cc View 1 2 3 chunks +4 lines, -7 lines 0 comments Download
D webrtc/modules/audio_processing/aecm/aecm_core_mips.c View 1 chunk +0 lines, -1566 lines 0 comments Download
A + webrtc/modules/audio_processing/aecm/aecm_core_mips.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
D webrtc/modules/audio_processing/aecm/aecm_core_neon.c View 1 chunk +0 lines, -212 lines 0 comments Download
A + webrtc/modules/audio_processing/aecm/aecm_core_neon.cc View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D webrtc/modules/audio_processing/aecm/echo_control_mobile.c View 1 chunk +0 lines, -646 lines 0 comments Download
A + webrtc/modules/audio_processing/aecm/echo_control_mobile.cc View 1 10 chunks +13 lines, -11 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
peah-webrtc
4 years, 8 months ago (2016-04-05 08:40:21 UTC) #3
ivoc
Nice, LGTM.
4 years, 8 months ago (2016-04-05 09:06:09 UTC) #4
hlundin-webrtc
Nice and readable CL. LGTM.
4 years, 8 months ago (2016-04-05 09:14:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857153002/20001
4 years, 8 months ago (2016-04-05 09:16:43 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/8771) ios_arm64_rel on tryserver.webrtc (JOB_FAILED, ...
4 years, 8 months ago (2016-04-05 09:18:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857153002/60001
4 years, 8 months ago (2016-04-09 21:23:03 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4699)
4 years, 8 months ago (2016-04-09 21:37:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1857153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1857153002/80001
4 years, 8 months ago (2016-04-11 04:41:51 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 8 months ago (2016-04-11 05:38:19 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-11 05:38:25 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2704512f7b8000e2abec3c18b976d53b07fc244c
Cr-Commit-Position: refs/heads/master@{#12307}

Powered by Google App Engine
This is Rietveld 408576698