Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: webrtc/api/mediastreaminterface.h

Issue 1817473002: Delete VideoRendererInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix JavaVideoRendererWrapper. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/mediastreaminterface.h
diff --git a/webrtc/api/mediastreaminterface.h b/webrtc/api/mediastreaminterface.h
index 69a50c97a3311b0e3259be0ea638e932e33e47dc..d47abde9d67568a3f621f6e4673e26ab5238d94c 100644
--- a/webrtc/api/mediastreaminterface.h
+++ b/webrtc/api/mediastreaminterface.h
@@ -101,26 +101,6 @@ class MediaStreamTrackInterface : public rtc::RefCountInterface,
virtual ~MediaStreamTrackInterface() {}
};
-// Interface for rendering VideoFrames from a VideoTrack
-class VideoRendererInterface
- : public rtc::VideoSinkInterface<cricket::VideoFrame> {
- public:
- // |frame| may have pending rotation. For clients which can't apply rotation,
- // |frame|->GetCopyWithRotationApplied() will return a frame that has the
- // rotation applied.
- virtual void RenderFrame(const cricket::VideoFrame* frame) = 0;
- // Intended to replace RenderFrame.
- void OnFrame(const cricket::VideoFrame& frame) override {
- RenderFrame(&frame);
- }
-
- protected:
- // The destructor is protected to prevent deletion via the interface.
- // This is so that we allow reference counted classes, where the destructor
- // should never be public, to implement the interface.
- virtual ~VideoRendererInterface() {}
-};
-
// VideoTrackSourceInterface is a reference counted source used for VideoTracks.
// The same source can be used in multiple VideoTracks.
class VideoTrackSourceInterface
@@ -159,16 +139,6 @@ class VideoTrackInterface
: public MediaStreamTrackInterface,
public rtc::VideoSourceInterface<cricket::VideoFrame> {
public:
- // AddRenderer and RemoveRenderer are for backwards compatibility
- // only. They are obsoleted by the methods of
- // rtc::VideoSourceInterface.
- virtual void AddRenderer(VideoRendererInterface* renderer) {
- AddOrUpdateSink(renderer, rtc::VideoSinkWants());
- }
- virtual void RemoveRenderer(VideoRendererInterface* renderer) {
- RemoveSink(renderer);
- }
-
// Register a video sink for this track.
void AddOrUpdateSink(rtc::VideoSinkInterface<cricket::VideoFrame>* sink,
const rtc::VideoSinkWants& wants) override{};

Powered by Google App Engine
This is Rietveld 408576698