Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: webrtc/api/java/src/org/webrtc/VideoRenderer.java

Issue 1817473002: Delete VideoRendererInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fix JavaVideoRendererWrapper. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/java/src/org/webrtc/VideoRenderer.java
diff --git a/webrtc/api/java/src/org/webrtc/VideoRenderer.java b/webrtc/api/java/src/org/webrtc/VideoRenderer.java
index e33a6abe8f84c43dda9ab3a363fee90a2febcf34..bf57620cf9517d606bded51a4c6443c3fcc2c645 100644
--- a/webrtc/api/java/src/org/webrtc/VideoRenderer.java
+++ b/webrtc/api/java/src/org/webrtc/VideoRenderer.java
@@ -13,7 +13,7 @@ package org.webrtc;
import java.nio.ByteBuffer;
/**
- * Java version of VideoRendererInterface. In addition to allowing clients to
+ * Java version of VideoSinkInterface. In addition to allowing clients to
* define their own rendering behavior (by passing in a Callbacks object), this
* class also provides a createGui() method for creating a GUI-rendering window
* on various platforms.
@@ -106,7 +106,8 @@ public class VideoRenderer {
public static native void nativeCopyPlane(ByteBuffer src, int width,
int height, int srcStride, ByteBuffer dst, int dstStride);
- /** The real meat of VideoRendererInterface. */
+ /** The real meat of VideoSinkInterface.
+ * TODO(nisse): Can we rename to OnFrame? */
public static interface Callbacks {
// |frame| might have pending rotation and implementation of Callbacks
// should handle that by applying rotation during rendering. The callee

Powered by Google App Engine
This is Rietveld 408576698