webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java - Issue 1817473002: Delete VideoRendererInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java

Issue 1817473002: Delete VideoRendererInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix JavaVideoRendererWrapper. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java

diff --git a/webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java b/webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java

index dbd620868f5cb6b3f33ee2c5c8d5852b77cf4972..98e279abd42787879fe4816af48a92bc568ea8f7 100644

--- a/webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java

+++ b/webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java

@@ -31,7 +31,7 @@ import javax.microedition.khronos.egl.EGLContext;

* renderFrame() is asynchronous to avoid blocking the calling thread.

* This class is thread safe and handles access from potentially four different threads:

* Interaction from the main app in init, release, setMirror, and setScalingtype.

- * Interaction from C++ webrtc::VideoRendererInterface in renderFrame and canApplyRotation.

+ * Interaction from C++ rtc::VideoSinkInterface in renderFrame and canApplyRotation.

pthatcher1 2016/03/18 17:00:58 Isn't the comment about canApplyRotation out of da

nisse-webrtc 2016/03/21 08:37:56 Right, it seems the canApplyRotation method disapp

* Interaction from the Activity lifecycle in surfaceCreated, surfaceChanged, and surfaceDestroyed.

* Interaction with the layout framework in onMeasure and onSizeChanged.