Delete VideoRendererInterface.

talk/app/webrtc/objc/RTCVideoRendererAdapter.mm

Index: talk/app/webrtc/objc/RTCVideoRendererAdapter.mm
diff --git a/talk/app/webrtc/objc/RTCVideoRendererAdapter.mm b/talk/app/webrtc/objc/RTCVideoRendererAdapter.mm
index b0b21291b91604134b238003205022efa1b01a79..a7f7e95d05f9d8dbe11acd598ae15206ff85de35 100644
--- a/talk/app/webrtc/objc/RTCVideoRendererAdapter.mm
+++ b/talk/app/webrtc/objc/RTCVideoRendererAdapter.mm
@@ -36,15 +36,16 @@
 
 namespace webrtc {
 
-class RTCVideoRendererNativeAdapter : public VideoRendererInterface {
+class RTCVideoRendererNativeAdapter

[tkchin_webrtc, 2016/03/18 19:14:16]

we should eventually update these class names since videorenderer is a thing of
the past. If you don't mind doing it, then this would become

namespace webrtc {
class VideoSinkAdapter {
};
}

@interface RTCVideoRendererAdapter -> @interface RTCVideoSinkAdapter

Otherwise, please file a bug.

@protocol RTCVideoRenderer -> @protocol RTCVideoSink

[nisse-webrtc, 2016/03/21 08:37:55]

I think I'd prefer to delay as much work as possibly until the transition out of
talk/ is complete.

I've filed bug https://bugs.chromium.org/p/webrtc/issues/detail?id=5673

+    : public rtc::VideoSinkInterface<cricket::VideoFrame> {
  public:
   RTCVideoRendererNativeAdapter(RTCVideoRendererAdapter* adapter) {
     _adapter = adapter;
     _size = CGSizeZero;
   }
 
-  void RenderFrame(const cricket::VideoFrame* videoFrame) override {
-    const cricket::VideoFrame* frame = videoFrame->GetCopyWithRotationApplied();
+  void OnFrame(const cricket::VideoFrame& videoFrame) override {
+    const cricket::VideoFrame* frame = videoFrame.GetCopyWithRotationApplied();
     CGSize currentSize = CGSizeMake(frame->GetWidth(), frame->GetHeight());
     if (!CGSizeEqualToSize(_size, currentSize)) {
       _size = currentSize;
@@ -74,7 +75,7 @@ class RTCVideoRendererNativeAdapter : public VideoRendererInterface {
   return self;
 }
 
-- (webrtc::VideoRendererInterface*)nativeVideoRenderer {
+- (rtc::VideoSinkInterface<cricket::VideoFrame> *)nativeVideoRenderer {

[pthatcher1, 2016/03/18 17:00:58]

Same here

[tkchin_webrtc, 2016/03/18 19:14:16]

All good. The rules are weird in ObjC++ -> If it's a C/C++ function, C++ style
guide applies. If it is an ObjC method, ObjC rules apply.

So VideoFrame& in the C++ class above, but (rtc::..<.> *) here.

   return _adapter.get();
 }