talk/app/webrtc/objc/RTCVideoRendererAdapter.h - Issue 1817473002: Delete VideoRendererInterface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/objc/RTCVideoRendererAdapter.h

Issue 1817473002: Delete VideoRendererInterface. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fix JavaVideoRendererWrapper. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: talk/app/webrtc/objc/RTCVideoRendererAdapter.h

diff --git a/talk/app/webrtc/objc/RTCVideoRendererAdapter.h b/talk/app/webrtc/objc/RTCVideoRendererAdapter.h

index 77198608b6c7051e212918e44bc20229f7e146c9..117347ff9ad8fec8bcf797c57a68a31cdc602638 100644

--- a/talk/app/webrtc/objc/RTCVideoRendererAdapter.h

+++ b/talk/app/webrtc/objc/RTCVideoRendererAdapter.h

@@ -33,7 +33,7 @@

@property(nonatomic, readonly) id<RTCVideoRenderer> videoRenderer;

@property(nonatomic, readonly)

- webrtc::VideoRendererInterface* nativeVideoRenderer;

+ rtc::VideoSinkInterface<cricket::VideoFrame> *nativeVideoRenderer;

pthatcher1 2016/03/18 17:00:58 Is that * in the right place (looks wrong for C++,

tkchin_webrtc 2016/03/18 19:14:16 It is correct for ObjC

- (instancetype)initWithVideoRenderer:(id<RTCVideoRenderer>)videoRenderer;