Cleanup of webrtc::VideoRenderer

This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame --> OnFrame.

TBR=kjellander@webrtc.org
BUG=webrtc:5426
Committed: https://crrev.com/eb83a1a10fe7aa6b4b57ece4c7674ecf7f148f96
Cr-Commit-Position: refs/heads/master@{#12070}

[nisse-webrtc, 2016-03-17 09:53:51]

Description was changed from

==========
This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame
--> OnFrame.

BUG=webrtc:5426
==========

to

==========
This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame
--> OnFrame.

BUG=webrtc:5426
==========

[nisse-webrtc, 2016-03-17 09:54:37]

nisse@webrtc.org changed reviewers:
+ perkj@webrtc.org, pthatcher@webrtc.org

[nisse-webrtc, 2016-03-17 09:54:38]

For the next step, it's not yet clear to me where VideoRenderer is used. We need
to identify the places where it is attached, and make sure they are video
sources.

I'm not sure whether or not it makes sense to land this initial cleanup first?

[nisse-webrtc, 2016-03-17 10:18:47]

nisse@webrtc.org changed reviewers:
+ pbos@webrtc.org

[perkj_webrtc, 2016-03-17 12:05:49]

On 2016/03/17 10:18:48, nisse-webrtc wrote:

lgtm

[pbos-webrtc, 2016-03-17 14:47:23]

lgtm

https://codereview.webrtc.org/1814763002/diff/1/webrtc/video/video_receive_st...
File webrtc/video/video_receive_stream.cc (right):

https://codereview.webrtc.org/1814763002/diff/1/webrtc/video/video_receive_st...
webrtc/video/video_receive_stream.cc:391: // TODO(pbos): Wire up
config_.render->IsTextureSupported() and convert if not
Remove this TODO

[pthatcher1, 2016-03-17 18:24:45]

lgtm

I think it makes sense to land this cleanup first.

[nisse-webrtc, 2016-03-18 08:05:54]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-03-18 08:05:54]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1814763002/#ps20001 (title:
"Delete TODO comment.")

[commit-bot: I haz the power, 2016-03-18 08:05:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814763002/20001

[commit-bot: I haz the power, 2016-03-18 08:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 08:09:27]

Try jobs failed on following builders:
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/13621)

[nisse-webrtc, 2016-03-18 08:19:41]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-03-18 08:19:42]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
perkj@webrtc.org, pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1814763002/#ps40001 (title:
"Update MacOS and Windows renderers.")

[commit-bot: I haz the power, 2016-03-18 08:19:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814763002/40001

[commit-bot: I haz the power, 2016-03-18 08:30:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 08:30:40]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4237)

[nisse-webrtc, 2016-03-18 08:54:06]

nisse@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[nisse-webrtc, 2016-03-18 08:54:07]

kjellander: Is it right to simply add "+webrtc/media" in webrtc/DEPS?

[nisse-webrtc, 2016-03-18 08:54:29]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 08:54:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814763002/60001

[commit-bot: I haz the power, 2016-03-18 10:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 10:41:44]

Dry run: This issue passed the CQ dry run.

[kjellander_webrtc, 2016-03-18 10:51:33]

Replied regarding the DEPS rule

https://codereview.webrtc.org/1814763002/diff/60001/webrtc/DEPS
File webrtc/DEPS (right):

https://codereview.webrtc.org/1814763002/diff/60001/webrtc/DEPS#newcode34
webrtc/DEPS:34: "+webrtc/media",
Please don't add it here. This will make it possible for anything below webrtc/
to add a dependency on media. I think we should keep only the very core things
here, and specify all other check_deps rules on a per-module/dir basis.

[nisse-webrtc, 2016-03-18 11:10:08]

https://codereview.webrtc.org/1814763002/diff/60001/webrtc/DEPS
File webrtc/DEPS (right):

https://codereview.webrtc.org/1814763002/diff/60001/webrtc/DEPS#newcode34
webrtc/DEPS:34: "+webrtc/media",
On 2016/03/18 10:51:33, kjellander (webrtc) wrote:
> Please don't add it here. This will make it possible for anything below
webrtc/
> to add a dependency on media. I think we should keep only the very core things
> here, and specify all other check_deps rules on a per-module/dir basis.

What do you suggest I do instead? My understanding is that it should be ok to
include webrtc/media/base/videosinkinterface.h (and videosourceinterface.h) from
more or less anywhere.

Would "+webrtc/media/base" be acceptable?

Or is the real problem that video_renderer.h is not yet moved from the top-level
directory? So a specific rule for that file would be more appropriate (until it
is moved or deleted, whatever happens first)?

[nisse-webrtc, 2016-03-18 13:31:00]

Now with a more limited rule in webrtc/DEPS.

[kjellander_webrtc, 2016-03-18 14:18:44]

lgtm now. Let's move the header file out of here in future CL though.

https://codereview.webrtc.org/1814763002/diff/80001/webrtc/DEPS
File webrtc/DEPS (right):

https://codereview.webrtc.org/1814763002/diff/80001/webrtc/DEPS#newcode47
webrtc/DEPS:47: "video_renderer\.h": [
This is OK for now, but video_renderer.h should really move out of webrtc/ (we
shouldn't have any headers in that location essentially, since it encourages
putting stuff into the monolithic 'webrtc' target).

[nisse-webrtc, 2016-03-18 14:28:59]

The CQ bit was checked by nisse@webrtc.org

[nisse-webrtc, 2016-03-18 14:28:59]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
perkj@webrtc.org, pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1814763002/#ps80001 (title:
"Use a more specific DEPS rule.")

[commit-bot: I haz the power, 2016-03-18 14:29:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814763002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814763002/80001

[commit-bot: I haz the power, 2016-03-18 14:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 14:33:35]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4260)

[nisse-webrtc, 2016-03-18 15:05:26]

Description was changed from

==========
This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame
--> OnFrame.

BUG=webrtc:5426
==========

to

==========
This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame
--> OnFrame.

TBR=kjellander@webrtc.org
BUG=webrtc:5426
==========

[nisse-webrtc, 2016-03-18 15:05:49]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-03-18 15:05:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814763002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814763002/80001

[nisse-webrtc, 2016-03-18 16:04:25]

The CQ bit was unchecked by nisse@webrtc.org

[nisse-webrtc, 2016-03-18 16:05:01]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-18 16:05:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814763002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814763002/80001

[commit-bot: I haz the power, 2016-03-18 16:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-18 16:29:38]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[nisse-webrtc, 2016-03-21 07:20:20]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-03-21 07:20:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1814763002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1814763002/80001

[commit-bot: I haz the power, 2016-03-21 08:28:00]

Description was changed from

==========
This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame
--> OnFrame.

TBR=kjellander@webrtc.org
BUG=webrtc:5426
==========

to

==========
This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame
--> OnFrame.

TBR=kjellander@webrtc.org
BUG=webrtc:5426
==========

[commit-bot: I haz the power, 2016-03-21 08:28:02]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-03-21 08:28:16]

Description was changed from

==========
This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame
--> OnFrame.

TBR=kjellander@webrtc.org
BUG=webrtc:5426
==========

to

==========
This is an initial cleanup step, aiming to delete the
webrtc::VideoRenderer class, replacing it by rtc::VideoSinkInterface.

The next step is to convert all places where a renderer is attached to
rtc::VideoSourceInterface, and at that point, the
SmoothsRenderedFrames method can be replaced by a flag
rtc::VideoSinkWants::smoothed_frames.

Delete unused method IsTextureSupported.
Delete unused time argument to RenderFrame.
Let webrtc::VideoRenderer inherit rtc::VideoSinkInterface. Rename RenderFrame
--> OnFrame.

TBR=kjellander@webrtc.org
BUG=webrtc:5426

Committed: https://crrev.com/eb83a1a10fe7aa6b4b57ece4c7674ecf7f148f96
Cr-Commit-Position: refs/heads/master@{#12070}
==========

[commit-bot: I haz the power, 2016-03-21 08:28:18]

Patchset 5 (id:??) landed as
https://crrev.com/eb83a1a10fe7aa6b4b57ece4c7674ecf7f148f96
Cr-Commit-Position: refs/heads/master@{#12070}