Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1625)

Unified Diff: webrtc/video/end_to_end_tests.cc

Issue 1814763002: Cleanup of webrtc::VideoRenderer (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Use a more specific DEPS rule. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video/end_to_end_tests.cc
diff --git a/webrtc/video/end_to_end_tests.cc b/webrtc/video/end_to_end_tests.cc
index 812c38e57bfbf578d5d0fbff332ecec9d785570d..b86b2c9d3013f2f5f516593fa83843fabbc7eefc 100644
--- a/webrtc/video/end_to_end_tests.cc
+++ b/webrtc/video/end_to_end_tests.cc
@@ -127,12 +127,7 @@ TEST_F(EndToEndTest, RendersSingleDelayedFrame) {
public:
Renderer() : event_(false, false) {}
- void RenderFrame(const VideoFrame& video_frame,
- int /*time_to_render_ms*/) override {
- event_.Set();
- }
-
- bool IsTextureSupported() const override { return false; }
+ void OnFrame(const VideoFrame& video_frame) override { event_.Set(); }
bool Wait() { return event_.Wait(kDefaultTimeoutMs); }
@@ -195,11 +190,7 @@ TEST_F(EndToEndTest, TransmitsFirstFrame) {
public:
Renderer() : event_(false, false) {}
- void RenderFrame(const VideoFrame& video_frame,
- int /*time_to_render_ms*/) override {
- event_.Set();
- }
- bool IsTextureSupported() const override { return false; }
+ void OnFrame(const VideoFrame& video_frame) override { event_.Set(); }
bool Wait() { return event_.Wait(kDefaultTimeoutMs); }
@@ -272,15 +263,12 @@ TEST_F(EndToEndTest, SendsAndReceivesVP9) {
(*receive_configs)[0].decoders[0].decoder = decoder_.get();
}
- void RenderFrame(const VideoFrame& video_frame,
- int time_to_render_ms) override {
+ void OnFrame(const VideoFrame& video_frame) override {
const int kRequiredFrames = 500;
if (++frame_counter_ == kRequiredFrames)
observation_complete_.Set();
}
- bool IsTextureSupported() const override { return false; }
-
private:
std::unique_ptr<webrtc::VideoEncoder> encoder_;
std::unique_ptr<webrtc::VideoDecoder> decoder_;
@@ -328,15 +316,12 @@ TEST_F(EndToEndTest, SendsAndReceivesH264) {
(*receive_configs)[0].decoders[0].decoder = decoder_.get();
}
- void RenderFrame(const VideoFrame& video_frame,
- int time_to_render_ms) override {
+ void OnFrame(const VideoFrame& video_frame) override {
const int kRequiredFrames = 500;
if (++frame_counter_ == kRequiredFrames)
observation_complete_.Set();
}
- bool IsTextureSupported() const override { return false; }
-
private:
std::unique_ptr<webrtc::VideoEncoder> encoder_;
std::unique_ptr<webrtc::VideoDecoder> decoder_;
@@ -521,8 +506,7 @@ TEST_F(EndToEndTest, CanReceiveFec) {
return SEND_PACKET;
}
- void RenderFrame(const VideoFrame& video_frame,
- int time_to_render_ms) override {
+ void OnFrame(const VideoFrame& video_frame) override {
rtc::CritScope lock(&crit_);
// Rendering frame with timestamp of packet that was dropped -> FEC
// protection worked.
@@ -530,8 +514,6 @@ TEST_F(EndToEndTest, CanReceiveFec) {
observation_complete_.Set();
}
- bool IsTextureSupported() const override { return false; }
-
enum {
kFirstPacket,
kDropEveryOtherPacketUntilFec,
@@ -850,16 +832,13 @@ TEST_F(EndToEndTest, UsesFrameCallbacks) {
public:
Renderer() : event_(false, false) {}
- void RenderFrame(const VideoFrame& video_frame,
- int /*time_to_render_ms*/) override {
+ void OnFrame(const VideoFrame& video_frame) override {
EXPECT_EQ(0, *video_frame.buffer(kYPlane))
<< "Rendered frame should have zero luma which is applied by the "
"pre-render callback.";
event_.Set();
}
- bool IsTextureSupported() const override { return false; }
-
bool Wait() { return event_.Wait(kDefaultTimeoutMs); }
rtc::Event event_;
} renderer;
@@ -997,8 +976,7 @@ void EndToEndTest::ReceivesPliAndRecovers(int rtp_history_ms) {
return SEND_PACKET;
}
- void RenderFrame(const VideoFrame& video_frame,
- int time_to_render_ms) override {
+ void OnFrame(const VideoFrame& video_frame) override {
rtc::CritScope lock(&crit_);
if (received_pli_ &&
video_frame.timestamp() > highest_dropped_timestamp_) {
@@ -1008,8 +986,6 @@ void EndToEndTest::ReceivesPliAndRecovers(int rtp_history_ms) {
frames_to_drop_ = kPacketsToDrop;
}
- bool IsTextureSupported() const override { return false; }
-
void ModifyVideoConfigs(
VideoSendStream::Config* send_config,
std::vector<VideoReceiveStream::Config>* receive_configs,
@@ -1323,8 +1299,7 @@ TEST_F(EndToEndTest, SendsAndReceivesMultipleStreams) {
frame_generator_(frame_generator),
done_(false, false) {}
- void RenderFrame(const VideoFrame& video_frame,
- int time_to_render_ms) override {
+ void OnFrame(const VideoFrame& video_frame) override {
EXPECT_EQ(settings_.width, video_frame.width());
EXPECT_EQ(settings_.height, video_frame.height());
(*frame_generator_)->Stop();
@@ -1333,8 +1308,6 @@ TEST_F(EndToEndTest, SendsAndReceivesMultipleStreams) {
uint32_t Ssrc() { return ssrc_; }
- bool IsTextureSupported() const override { return false; }
-
bool Wait() { return done_.Wait(kDefaultTimeoutMs); }
private:
« webrtc/DEPS ('K') | « webrtc/test/win/d3d_renderer.cc ('k') | webrtc/video/replay.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698