Cleanup of webrtc::VideoRenderer

webrtc/DEPS

 # Define rules for which include paths are allowed in our source.
 include_rules = [
   # Base is only used to build Android APK tests and may not be referenced by
   # WebRTC production code.
   "-base",
   "-chromium",
   "+external/webrtc/webrtc",  # Android platform build.
   "+gflags",
   "+libyuv",
   "+testing",
@@ skipping 13 matching lines @@
   "+webrtc/transport.h",
   "+webrtc/typedefs.h",
   "+webrtc/video_decoder.h",
   "+webrtc/video_encoder.h",
   "+webrtc/video_frame.h",
   "+webrtc/video_receive_stream.h",
   "+webrtc/video_renderer.h",
   "+webrtc/video_send_stream.h",
 
   "+webrtc/base",
+  "+webrtc/media",

[kjellander_webrtc, 2016/03/18 10:51:33]

Please don't add it here. This will make it possible for anything below webrtc/
to add a dependency on media. I think we should keep only the very core things
here, and specify all other check_deps rules on a per-module/dir basis.

[nisse-webrtc, 2016/03/18 11:10:08]

What do you suggest I do instead? My understanding is that it should be ok to
include webrtc/media/base/videosinkinterface.h (and videosourceinterface.h) from
more or less anywhere.

Would "+webrtc/media/base" be acceptable?

Or is the real problem that video_renderer.h is not yet moved from the top-level
directory? So a specific rule for that file would be more appropriate (until it
is moved or deleted, whatever happens first)?

   "+webrtc/modules/include",
   "+webrtc/test",
   "+webrtc/tools",
 ]
 
 # The below rules will be removed when webrtc: is fixed.
 specific_include_rules = {
   "audio_send_stream\.h": [
     "+webrtc/modules/audio_coding",
   ],
   "video_frame\.h": [
     "+webrtc/common_video",
   ],
 }