webrtc/modules/video_render/android/video_render_android_native_opengl2.h - Issue 1813173002: Deletes the class VideoRendererCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_render/android/video_render_android_native_opengl2.h

Issue 1813173002: Deletes the class VideoRendererCallback. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Break long lines. Add explicit keyword on IncomingVideoStream constructor. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_render/android/video_render_android_impl.cc ('k') | webrtc/modules/video_render/android/video_render_android_native_opengl2.cc » ('j') | webrtc/modules/video_render/external/video_render_external_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_render/android/video_render_android_native_opengl2.h

diff --git a/webrtc/modules/video_render/android/video_render_android_native_opengl2.h b/webrtc/modules/video_render/android/video_render_android_native_opengl2.h

index 8be247b8342c28f1023d3c2da061b254bae26f07..f32f208b1e63ab9dcc506967a16f6b9390e6a3c7 100644

--- a/webrtc/modules/video_render/android/video_render_android_native_opengl2.h

+++ b/webrtc/modules/video_render/android/video_render_android_native_opengl2.h

@@ -32,9 +32,8 @@ class AndroidNativeOpenGl2Channel: public AndroidStream {

int32_t Init(int32_t zOrder, const float left, const float top,

const float right, const float bottom);

- //Implement VideoRenderCallback

- virtual int32_t RenderFrame(const uint32_t streamId,

- const VideoFrame& videoFrame);

+ //Implement rtc::VideoSinkInterface<VideoFrame>

mflodman 2016/05/02 07:06:54 Old nit, but since changing: space after '//' and

+ void OnFrame(const VideoFrame& videoFrame) override;

//Implements AndroidStream

virtual void DeliverFrame(JNIEnv* jniEnv);