webrtc/modules/video_render/android/video_render_android_native_opengl2.cc - Issue 1813173002: Deletes the class VideoRendererCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_render/android/video_render_android_native_opengl2.cc

Issue 1813173002: Deletes the class VideoRendererCallback. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Break long lines. Add explicit keyword on IncomingVideoStream constructor. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_render/android/video_render_android_native_opengl2.h ('K') | « webrtc/modules/video_render/android/video_render_android_native_opengl2.h ('k') | webrtc/modules/video_render/android/video_render_android_surface_view.h » ('j') | webrtc/modules/video_render/external/video_render_external_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_render/android/video_render_android_native_opengl2.cc

diff --git a/webrtc/modules/video_render/android/video_render_android_native_opengl2.cc b/webrtc/modules/video_render/android/video_render_android_native_opengl2.cc

index 286776e317ba0ea8978b3d62ede1361cd718dc32..e42a8e2445b5523d041576c93e14ed9cbeb1035c 100644

--- a/webrtc/modules/video_render/android/video_render_android_native_opengl2.cc

+++ b/webrtc/modules/video_render/android/video_render_android_native_opengl2.cc

@@ -381,14 +381,12 @@ int32_t AndroidNativeOpenGl2Channel::Init(int32_t zOrder,

return 0;

}

-int32_t AndroidNativeOpenGl2Channel::RenderFrame(const uint32_t /*streamId*/,

- const VideoFrame& videoFrame) {

+void AndroidNativeOpenGl2Channel::OnFrame(const VideoFrame& videoFrame) {

// WEBRTC_TRACE(kTraceInfo, kTraceVideoRenderer,_id, "%s:" ,__FUNCTION__);

_renderCritSect.Enter();

_bufferToRender = videoFrame;

_renderCritSect.Leave();

_renderer.ReDraw();

- return 0;

}

/*Implements AndroidStream