Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1013)

Unified Diff: webrtc/modules/video_render/external/video_render_external_impl.h

Issue 1813173002: Deletes the class VideoRendererCallback. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Break long lines. Add explicit keyword on IncomingVideoStream constructor. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_render/external/video_render_external_impl.h
diff --git a/webrtc/modules/video_render/external/video_render_external_impl.h b/webrtc/modules/video_render/external/video_render_external_impl.h
index a8b663fff7ee7aec9e86aecd22df133021080f50..b95d425249dfc6b011064dfad89bc726efbc87fb 100644
--- a/webrtc/modules/video_render/external/video_render_external_impl.h
+++ b/webrtc/modules/video_render/external/video_render_external_impl.h
@@ -18,7 +18,8 @@
namespace webrtc {
// Class definitions
-class VideoRenderExternalImpl: IVideoRender, public VideoRenderCallback
+class VideoRenderExternalImpl: IVideoRender,
+ public rtc::VideoSinkInterface<VideoFrame>
{
public:
/*
@@ -41,7 +42,7 @@ public:
*
***************************************************************************/
- virtual VideoRenderCallback
+ virtual rtc::VideoSinkInterface<VideoFrame>
* AddIncomingRenderStream(const uint32_t streamId,
const uint32_t zOrder,
const float left, const float top,
@@ -113,9 +114,8 @@ public:
const float top, const float right,
const float bottom);
- // VideoRenderCallback
- virtual int32_t RenderFrame(const uint32_t streamId,
- const VideoFrame& videoFrame);
+ // rtc::VideoSinkInterface<VideoFrame>
mflodman 2016/05/02 07:06:54 Add 'Implements'.
+ void OnFrame(const VideoFrame& videoFrame) override;
private:
CriticalSectionWrapper& _critSect;

Powered by Google App Engine
This is Rietveld 408576698