Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1811933002: [rtcp] Pli::Parse updated not to use RTCPUtility (Closed)

Created:
4 years, 9 months ago by danilchap
Modified:
4 years, 9 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

[rtcp] Pli::Parse updated not to use RTCPUtility BUG=webrtc:5260 R=åsapersson Committed: https://crrev.com/f752f85f3dc3b0306262a7d77466059107f4dc84 Cr-Commit-Position: refs/heads/master@{#12104}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -31 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h View 1 2 chunks +3 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc View 1 2 chunks +6 lines, -7 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc View 2 chunks +12 lines, -17 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
danilchap
4 years, 9 months ago (2016-03-22 18:20:37 UTC) #2
åsapersson
lgtm
4 years, 9 months ago (2016-03-23 12:34:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811933002/20001
4 years, 9 months ago (2016-03-23 12:51:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 9 months ago (2016-03-23 14:52:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811933002/20001
4 years, 9 months ago (2016-03-23 15:02:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 15:25:29 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 15:25:38 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f752f85f3dc3b0306262a7d77466059107f4dc84
Cr-Commit-Position: refs/heads/master@{#12104}

Powered by Google App Engine
This is Rietveld 408576698