Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc

Issue 1811933002: [rtcp] Pli::Parse updated not to use RTCPUtility (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc
diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc b/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc
index 367349105830025cf544cf256b19e227743bd927..7fdcc1633a0b95ff62d79f88cec29ca511ee4486 100644
--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc
+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc
@@ -12,8 +12,7 @@
#include "webrtc/base/checks.h"
#include "webrtc/base/logging.h"
-
-using webrtc::RTCPUtility::RtcpCommonHeader;
+#include "webrtc/modules/rtp_rtcp/source/rtcp_packet/common_header.h"
namespace webrtc {
namespace rtcp {
@@ -37,16 +36,16 @@ namespace rtcp {
//
// Picture loss indication (PLI) (RFC 4585).
// FCI: no feedback control information.
-bool Pli::Parse(const RtcpCommonHeader& header, const uint8_t* payload) {
- RTC_DCHECK(header.packet_type == kPacketType);
- RTC_DCHECK(header.count_or_format == kFeedbackMessageType);
+bool Pli::Parse(const CommonHeader& packet) {
+ RTC_DCHECK(packet.type() == kPacketType);
+ RTC_DCHECK(packet.fmt() == kFeedbackMessageType);
- if (header.payload_size_bytes < kCommonFeedbackLength) {
+ if (packet.payload_size_bytes() < kCommonFeedbackLength) {
LOG(LS_WARNING) << "Packet is too small to be a valid PLI packet";
return false;
}
- ParseCommonFeedback(payload);
+ ParseCommonFeedback(packet.payload());
return true;
}
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h ('k') | webrtc/modules/rtp_rtcp/source/rtcp_packet/pli_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698