Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.h

Issue 1811933002: [rtcp] Pli::Parse updated not to use RTCPUtility (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 *
10 */ 9 */
11
12 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_ 10 #ifndef WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_
13 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_ 11 #define WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_
14 12
15 #include "webrtc/base/basictypes.h" 13 #include "webrtc/base/basictypes.h"
16 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h" 14 #include "webrtc/modules/rtp_rtcp/source/rtcp_packet/psfb.h"
17 15
18 namespace webrtc { 16 namespace webrtc {
19 namespace rtcp { 17 namespace rtcp {
20 18 class CommonHeader;
21 // Picture loss indication (PLI) (RFC 4585). 19 // Picture loss indication (PLI) (RFC 4585).
22 class Pli : public Psfb { 20 class Pli : public Psfb {
23 public: 21 public:
24 static const uint8_t kFeedbackMessageType = 1; 22 static const uint8_t kFeedbackMessageType = 1;
25 23
26 Pli() {} 24 Pli() {}
27 virtual ~Pli() {} 25 ~Pli() override {}
28 26
29 // Parse assumes header is already parsed and validated. 27 bool Parse(const CommonHeader& packet);
30 bool Parse(const RTCPUtility::RtcpCommonHeader& header,
31 const uint8_t* payload); // Size of the payload is in the header.
32 28
33 protected: 29 protected:
34 bool Create(uint8_t* packet, 30 bool Create(uint8_t* packet,
35 size_t* index, 31 size_t* index,
36 size_t max_length, 32 size_t max_length,
37 RtcpPacket::PacketReadyCallback* callback) const override; 33 RtcpPacket::PacketReadyCallback* callback) const override;
38 34
39 private: 35 private:
40 size_t BlockLength() const override { 36 size_t BlockLength() const override {
41 return kHeaderLength + kCommonFeedbackLength; 37 return kHeaderLength + kCommonFeedbackLength;
42 } 38 }
43 39
44 RTC_DISALLOW_COPY_AND_ASSIGN(Pli); 40 RTC_DISALLOW_COPY_AND_ASSIGN(Pli);
45 }; 41 };
46 42
47 } // namespace rtcp 43 } // namespace rtcp
48 } // namespace webrtc 44 } // namespace webrtc
49 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_ 45 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_PACKET_PLI_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet/pli.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698