Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 1803923003: Clean away use of RtpAudioFeedback interface from RTP/RTCP sender code. (Closed)

Created:
4 years, 9 months ago by the sun
Modified:
4 years, 9 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, danilchap, zhuangzesen_agora.io, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, pbos-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Clean away use of RtpAudioFeedback interface from RTP/RTCP sender code. BUG=webrtc:4690 Committed: https://crrev.com/6021fe2b1e4c7d55cca92ef01cc2750516aa3e9f Cr-Commit-Position: refs/heads/master@{#12003}

Patch Set 1 #

Patch Set 2 : revert #

Patch Set 3 : unused variable #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -51 lines) Patch
M webrtc/call/rtc_event_log_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/include/rtp_rtcp.h View 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.h View 2 chunks +1 line, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_audio.cc View 1 2 3 chunks +1 line, -10 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_sender_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/rtp_rtcp/test/testAPI/test_api_audio.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel.h View 2 chunks +0 lines, -6 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 4 chunks +1 line, -12 lines 0 comments Download
M webrtc/voice_engine/include/voe_errors.h View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803923003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803923003/20001
4 years, 9 months ago (2016-03-15 09:14:50 UTC) #2
the sun
4 years, 9 months ago (2016-03-15 09:15:19 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/2448) android_gn_dbg on ...
4 years, 9 months ago (2016-03-15 09:18:01 UTC) #6
hlundin-webrtc
lgtm
4 years, 9 months ago (2016-03-15 14:11:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803923003/60001
4 years, 9 months ago (2016-03-15 14:18:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_baremetal on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_baremetal/builds/9855)
4 years, 9 months ago (2016-03-15 14:39:00 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1803923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1803923003/60001
4 years, 9 months ago (2016-03-15 17:18:30 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 9 months ago (2016-03-15 18:41:58 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 18:42:05 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6021fe2b1e4c7d55cca92ef01cc2750516aa3e9f
Cr-Commit-Position: refs/heads/master@{#12003}

Powered by Google App Engine
This is Rietveld 408576698