webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc - Issue 1803923003: Clean away use of RtpAudioFeedback interface from RTP/RTCP sender code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 1803923003: Clean away use of RtpAudioFeedback interface from RTP/RTCP sender code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

index e67b635214280edad9f27856b5ab9213ada405e8..ef720bef524cf7ab8108d189a6cbb3795605a885 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

@@ -54,7 +54,6 @@ RtpRtcp::Configuration::Configuration()

transport_feedback_callback(nullptr),

rtt_stats(nullptr),

rtcp_packet_type_counter_observer(nullptr),

- audio_messages(NullObjectRtpAudioFeedback()),

remote_bitrate_estimator(nullptr),

paced_sender(nullptr),

transport_sequence_number_allocator(nullptr),

@@ -80,7 +79,6 @@ ModuleRtpRtcpImpl::ModuleRtpRtcpImpl(const Configuration& configuration)

: rtp_sender_(configuration.audio,

configuration.clock,

configuration.outgoing_transport,

- configuration.audio_messages,

configuration.paced_sender,

configuration.transport_sequence_number_allocator,

configuration.transport_feedback_callback,

« no previous file with comments | « webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h ('k') | webrtc/modules/rtp_rtcp/source/rtp_sender.h » ('j') | no next file with comments »