Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp.h

Issue 1803923003: Clean away use of RtpAudioFeedback interface from RTP/RTCP sender code. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/call/rtc_event_log_unittest.cc ('k') | webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 * data. May not be NULL; default callback will do 48 * data. May not be NULL; default callback will do
49 * nothing. 49 * nothing.
50 * incoming_messages - Callback object that will receive the incoming 50 * incoming_messages - Callback object that will receive the incoming
51 * RTP messages. May not be NULL; default callback 51 * RTP messages. May not be NULL; default callback
52 * will do nothing. 52 * will do nothing.
53 * outgoing_transport - Transport object that will be called when packets 53 * outgoing_transport - Transport object that will be called when packets
54 * are ready to be sent out on the network 54 * are ready to be sent out on the network
55 * intra_frame_callback - Called when the receiver request a intra frame. 55 * intra_frame_callback - Called when the receiver request a intra frame.
56 * bandwidth_callback - Called when we receive a changed estimate from 56 * bandwidth_callback - Called when we receive a changed estimate from
57 * the receiver of out stream. 57 * the receiver of out stream.
58 * audio_messages - Telephone events. May not be NULL; default
59 * callback will do nothing.
60 * remote_bitrate_estimator - Estimates the bandwidth available for a set of 58 * remote_bitrate_estimator - Estimates the bandwidth available for a set of
61 * streams from the same client. 59 * streams from the same client.
62 * paced_sender - Spread any bursts of packets into smaller 60 * paced_sender - Spread any bursts of packets into smaller
63 * bursts to minimize packet loss. 61 * bursts to minimize packet loss.
64 */ 62 */
65 bool audio; 63 bool audio;
66 bool receiver_only; 64 bool receiver_only;
67 Clock* clock; 65 Clock* clock;
68 ReceiveStatistics* receive_statistics; 66 ReceiveStatistics* receive_statistics;
69 Transport* outgoing_transport; 67 Transport* outgoing_transport;
70 RtcpIntraFrameObserver* intra_frame_callback; 68 RtcpIntraFrameObserver* intra_frame_callback;
71 RtcpBandwidthObserver* bandwidth_callback; 69 RtcpBandwidthObserver* bandwidth_callback;
72 TransportFeedbackObserver* transport_feedback_callback; 70 TransportFeedbackObserver* transport_feedback_callback;
73 RtcpRttStats* rtt_stats; 71 RtcpRttStats* rtt_stats;
74 RtcpPacketTypeCounterObserver* rtcp_packet_type_counter_observer; 72 RtcpPacketTypeCounterObserver* rtcp_packet_type_counter_observer;
75 RtpAudioFeedback* audio_messages;
76 RemoteBitrateEstimator* remote_bitrate_estimator; 73 RemoteBitrateEstimator* remote_bitrate_estimator;
77 RtpPacketSender* paced_sender; 74 RtpPacketSender* paced_sender;
78 TransportSequenceNumberAllocator* transport_sequence_number_allocator; 75 TransportSequenceNumberAllocator* transport_sequence_number_allocator;
79 BitrateStatisticsObserver* send_bitrate_observer; 76 BitrateStatisticsObserver* send_bitrate_observer;
80 FrameCountObserver* send_frame_count_observer; 77 FrameCountObserver* send_frame_count_observer;
81 SendSideDelayObserver* send_side_delay_observer; 78 SendSideDelayObserver* send_side_delay_observer;
82 RtcEventLog* event_log; 79 RtcEventLog* event_log;
83 80
84 RTC_DISALLOW_COPY_AND_ASSIGN(Configuration); 81 RTC_DISALLOW_COPY_AND_ASSIGN(Configuration);
85 }; 82 };
(...skipping 574 matching lines...) Expand 10 before | Expand all | Expand 10 after
660 657
661 /* 658 /*
662 * send a request for a keyframe 659 * send a request for a keyframe
663 * 660 *
664 * return -1 on failure else 0 661 * return -1 on failure else 0
665 */ 662 */
666 virtual int32_t RequestKeyFrame() = 0; 663 virtual int32_t RequestKeyFrame() = 0;
667 }; 664 };
668 } // namespace webrtc 665 } // namespace webrtc
669 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_ 666 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_H_
OLDNEW
« no previous file with comments | « webrtc/call/rtc_event_log_unittest.cc ('k') | webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698