Renamed new EncodeInternal to EncodeImpl to ensure proper backwards compatibility.

Renamed new EncodeInternal to EncodeImpl to ensure proper backwards compatibility.

Renamed the new variant of EncodeInternal to EncodeImpl, so that
subclasses implementing one of the EncodeInternal don't need to
explicitly contain 'using AudioEncoder::EncodeInternal' to avoid their
implementation hiding the other variant of EncodeInternal. This causes
a warning (treated as an error) when building using GCC.

Committed: https://crrev.com/4f43fcfd496485e5dc866231de0fd1d298442cfa
Cr-Commit-Position: refs/heads/master@{#11868}

[ossu, 2016-03-03 13:25:36]

Description was changed from

==========
Renamed new EncodeInternal to EncodeImpl to ensure proper backwards
compatibility.

Renamed the new variant of EncodeInternal to EncodeImpl, so that
subclasses implementing one of the EncodeInternal don't need to
explicitly contain 'using AudioEncoder::EncodeInternal' to avoid their
implementation hiding the other variant of EncodeInternal. This causes
a warning (treated as an error) when building using GCC.
==========

to

==========
Renamed new EncodeInternal to EncodeImpl to ensure proper backwards
compatibility.

Renamed the new variant of EncodeInternal to EncodeImpl, so that
subclasses implementing one of the EncodeInternal don't need to
explicitly contain 'using AudioEncoder::EncodeInternal' to avoid their
implementation hiding the other variant of EncodeInternal. This causes
a warning (treated as an error) when building using GCC.
==========

[ossu, 2016-03-03 13:25:36]

ossu@webrtc.org changed reviewers:
+ kwiberg@webrtc.org

[ossu, 2016-03-03 13:29:47]

The CQ bit was checked by ossu@webrtc.org

[commit-bot: I haz the power, 2016-03-03 13:29:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764583003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764583003/1

[commit-bot: I haz the power, 2016-03-03 13:30:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 13:30:01]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-webrtc-committers".
Note that this has nothing to do with OWNERS files.

[kwiberg-webrtc, 2016-03-03 13:39:15]

lgtm

https://codereview.webrtc.org/1764583003/diff/1/webrtc/modules/audio_coding/c...
File webrtc/modules/audio_coding/codecs/audio_encoder.h (right):

https://codereview.webrtc.org/1764583003/diff/1/webrtc/modules/audio_coding/c...
webrtc/modules/audio_coding/codecs/audio_encoder.h:168: // Preferably this one.
This comment needs some tweaking.

[ossu, 2016-03-03 14:23:39]

Updated the comments to better reflect reality.
Are we good to go or do we need another hero .. uhm .. reviewer?

[kwiberg-webrtc, 2016-03-03 14:34:26]

On 2016/03/03 14:23:39, ossu wrote:
> Updated the comments to better reflect reality.
> Are we good to go or do we need another hero .. uhm .. reviewer?

No, I don't think so.

(Don't forget to send a follow-up to your announcement mail once this has
landed, by the way.)

[ossu, 2016-03-03 14:40:03]

The CQ bit was checked by ossu@webrtc.org

[ossu, 2016-03-03 14:40:03]

The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1764583003/#ps20001 (title:
"Clarified doc comments in AudioEncoder.")

[commit-bot: I haz the power, 2016-03-03 14:40:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764583003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764583003/20001

[commit-bot: I haz the power, 2016-03-03 16:40:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 16:40:51]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_dbg on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  android_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
  win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[ossu, 2016-03-04 08:52:14]

The CQ bit was checked by ossu@webrtc.org

[commit-bot: I haz the power, 2016-03-04 08:52:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1764583003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1764583003/20001

[commit-bot: I haz the power, 2016-03-04 08:54:35]

Description was changed from

==========
Renamed new EncodeInternal to EncodeImpl to ensure proper backwards
compatibility.

Renamed the new variant of EncodeInternal to EncodeImpl, so that
subclasses implementing one of the EncodeInternal don't need to
explicitly contain 'using AudioEncoder::EncodeInternal' to avoid their
implementation hiding the other variant of EncodeInternal. This causes
a warning (treated as an error) when building using GCC.
==========

to

==========
Renamed new EncodeInternal to EncodeImpl to ensure proper backwards
compatibility.

Renamed the new variant of EncodeInternal to EncodeImpl, so that
subclasses implementing one of the EncodeInternal don't need to
explicitly contain 'using AudioEncoder::EncodeInternal' to avoid their
implementation hiding the other variant of EncodeInternal. This causes
a warning (treated as an error) when building using GCC.
==========

[commit-bot: I haz the power, 2016-03-04 08:54:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-04 08:54:43]

Description was changed from

==========
Renamed new EncodeInternal to EncodeImpl to ensure proper backwards
compatibility.

Renamed the new variant of EncodeInternal to EncodeImpl, so that
subclasses implementing one of the EncodeInternal don't need to
explicitly contain 'using AudioEncoder::EncodeInternal' to avoid their
implementation hiding the other variant of EncodeInternal. This causes
a warning (treated as an error) when building using GCC.
==========

to

==========
Renamed new EncodeInternal to EncodeImpl to ensure proper backwards
compatibility.

Renamed the new variant of EncodeInternal to EncodeImpl, so that
subclasses implementing one of the EncodeInternal don't need to
explicitly contain 'using AudioEncoder::EncodeInternal' to avoid their
implementation hiding the other variant of EncodeInternal. This causes
a warning (treated as an error) when building using GCC.

Committed: https://crrev.com/4f43fcfd496485e5dc866231de0fd1d298442cfa
Cr-Commit-Position: refs/heads/master@{#11868}
==========

[commit-bot: I haz the power, 2016-03-04 08:54:44]

Patchset 2 (id:??) landed as
https://crrev.com/4f43fcfd496485e5dc866231de0fd1d298442cfa
Cr-Commit-Position: refs/heads/master@{#11868}