webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h - Issue 1764583003: Renamed new EncodeInternal to EncodeImpl to ensure proper backwards compatibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

Issue 1764583003: Renamed new EncodeInternal to EncodeImpl to ensure proper backwards compatibility. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Clarified doc comments in AudioEncoder. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc ('k') | webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

diff --git a/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h b/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

index 2e15fb562000ba40793fb36c086a43658c196e58..e840f3b1b186cbe839acbfa8c9cdc6ce70c4a9d3 100644

--- a/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

+++ b/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

@@ -23,8 +23,6 @@ struct CodecInst;

template <typename T>

class AudioEncoderIsacT final : public AudioEncoder {

public:

- using AudioEncoder::EncodeInternal;

// Allowed combinations of sample rate, frame size, and bit rate are

// - 16000 Hz, 30 ms, 10000-32000 bps

// - 16000 Hz, 60 ms, 10000-32000 bps

@@ -62,9 +60,9 @@ class AudioEncoderIsacT final : public AudioEncoder {

size_t Num10MsFramesInNextPacket() const override;

size_t Max10MsFramesInAPacket() const override;

int GetTargetBitrate() const override;

- EncodedInfo EncodeInternal(uint32_t rtp_timestamp,

- rtc::ArrayView<const int16_t> audio,

- rtc::Buffer* encoded) override;

+ EncodedInfo EncodeImpl(uint32_t rtp_timestamp,

+ rtc::ArrayView<const int16_t> audio,

+ rtc::Buffer* encoded) override;

void Reset() override;

private: