Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1749103003: Replace scoped_ptr with unique_ptr in webrtc/common_video/ (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
tommi, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@up6
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/common_video/ BUG=webrtc:5520 Committed: https://crrev.com/c891eb479b22de0386dbf4f2fd60b23737538cfd Cr-Commit-Position: refs/heads/master@{#11838}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -24 lines) Patch
M webrtc/common_video/i420_video_frame_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/include/incoming_video_stream.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/common_video/include/video_frame_buffer.h View 2 chunks +5 lines, -2 lines 0 comments Download
M webrtc/common_video/libyuv/libyuv_unittest.cc View 10 chunks +12 lines, -11 lines 0 comments Download
M webrtc/common_video/libyuv/scaler_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/test/linux/glx_renderer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/testsupport/metrics/video_metrics.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video_decoder.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/video_encoder.h View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1738863002 Patch 40001

Messages

Total messages: 13 (6 generated)
kwiberg-webrtc
4 years, 9 months ago (2016-03-01 15:06:15 UTC) #4
pbos-webrtc
lgtm
4 years, 9 months ago (2016-03-01 22:34:57 UTC) #5
kwiberg-webrtc
tommi@ for the two files at top level in webrtc/
4 years, 9 months ago (2016-03-02 09:02:05 UTC) #7
tommi
lgtm
4 years, 9 months ago (2016-03-02 11:17:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1749103003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1749103003/40001
4 years, 9 months ago (2016-03-02 11:39:36 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 9 months ago (2016-03-02 11:41:37 UTC) #11
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 11:41:47 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c891eb479b22de0386dbf4f2fd60b23737538cfd
Cr-Commit-Position: refs/heads/master@{#11838}

Powered by Google App Engine
This is Rietveld 408576698