Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: webrtc/common_video/include/incoming_video_stream.h

Issue 1749103003: Replace scoped_ptr with unique_ptr in webrtc/common_video/ (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@up6
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_COMMON_VIDEO_INCLUDE_INCOMING_VIDEO_STREAM_H_ 11 #ifndef WEBRTC_COMMON_VIDEO_INCLUDE_INCOMING_VIDEO_STREAM_H_
12 #define WEBRTC_COMMON_VIDEO_INCLUDE_INCOMING_VIDEO_STREAM_H_ 12 #define WEBRTC_COMMON_VIDEO_INCLUDE_INCOMING_VIDEO_STREAM_H_
13 13
14 #include <memory>
15
14 #include "webrtc/base/criticalsection.h" 16 #include "webrtc/base/criticalsection.h"
15 #include "webrtc/base/platform_thread.h" 17 #include "webrtc/base/platform_thread.h"
16 #include "webrtc/base/scoped_ptr.h"
17 #include "webrtc/base/thread_annotations.h" 18 #include "webrtc/base/thread_annotations.h"
18 #include "webrtc/common_video/video_render_frames.h" 19 #include "webrtc/common_video/video_render_frames.h"
19 20
20 namespace webrtc { 21 namespace webrtc {
21 class EventTimerWrapper; 22 class EventTimerWrapper;
22 23
23 class VideoRenderCallback { 24 class VideoRenderCallback {
24 public: 25 public:
25 virtual int32_t RenderFrame(const uint32_t streamId, 26 virtual int32_t RenderFrame(const uint32_t streamId,
26 const VideoFrame& videoFrame) = 0; 27 const VideoFrame& videoFrame) = 0;
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 void DeliverFrame(const VideoFrame& video_frame); 76 void DeliverFrame(const VideoFrame& video_frame);
76 77
77 uint32_t const stream_id_; 78 uint32_t const stream_id_;
78 const bool disable_prerenderer_smoothing_; 79 const bool disable_prerenderer_smoothing_;
79 // Critsects in allowed to enter order. 80 // Critsects in allowed to enter order.
80 rtc::CriticalSection stream_critsect_; 81 rtc::CriticalSection stream_critsect_;
81 rtc::CriticalSection thread_critsect_; 82 rtc::CriticalSection thread_critsect_;
82 rtc::CriticalSection buffer_critsect_; 83 rtc::CriticalSection buffer_critsect_;
83 // TODO(pbos): Make plain member and stop resetting this thread, just 84 // TODO(pbos): Make plain member and stop resetting this thread, just
84 // start/stoping it is enough. 85 // start/stoping it is enough.
85 rtc::scoped_ptr<rtc::PlatformThread> incoming_render_thread_ 86 std::unique_ptr<rtc::PlatformThread> incoming_render_thread_
86 GUARDED_BY(thread_critsect_); 87 GUARDED_BY(thread_critsect_);
87 rtc::scoped_ptr<EventTimerWrapper> deliver_buffer_event_; 88 std::unique_ptr<EventTimerWrapper> deliver_buffer_event_;
88 89
89 bool running_ GUARDED_BY(stream_critsect_); 90 bool running_ GUARDED_BY(stream_critsect_);
90 VideoRenderCallback* external_callback_ GUARDED_BY(thread_critsect_); 91 VideoRenderCallback* external_callback_ GUARDED_BY(thread_critsect_);
91 VideoRenderCallback* render_callback_ GUARDED_BY(thread_critsect_); 92 VideoRenderCallback* render_callback_ GUARDED_BY(thread_critsect_);
92 const rtc::scoped_ptr<VideoRenderFrames> render_buffers_ 93 const std::unique_ptr<VideoRenderFrames> render_buffers_
93 GUARDED_BY(buffer_critsect_); 94 GUARDED_BY(buffer_critsect_);
94 95
95 uint32_t incoming_rate_ GUARDED_BY(stream_critsect_); 96 uint32_t incoming_rate_ GUARDED_BY(stream_critsect_);
96 int64_t last_rate_calculation_time_ms_ GUARDED_BY(stream_critsect_); 97 int64_t last_rate_calculation_time_ms_ GUARDED_BY(stream_critsect_);
97 uint16_t num_frames_since_last_calculation_ GUARDED_BY(stream_critsect_); 98 uint16_t num_frames_since_last_calculation_ GUARDED_BY(stream_critsect_);
98 int64_t last_render_time_ms_ GUARDED_BY(thread_critsect_); 99 int64_t last_render_time_ms_ GUARDED_BY(thread_critsect_);
99 VideoFrame temp_frame_ GUARDED_BY(thread_critsect_); 100 VideoFrame temp_frame_ GUARDED_BY(thread_critsect_);
100 VideoFrame start_image_ GUARDED_BY(thread_critsect_); 101 VideoFrame start_image_ GUARDED_BY(thread_critsect_);
101 VideoFrame timeout_image_ GUARDED_BY(thread_critsect_); 102 VideoFrame timeout_image_ GUARDED_BY(thread_critsect_);
102 uint32_t timeout_time_ GUARDED_BY(thread_critsect_); 103 uint32_t timeout_time_ GUARDED_BY(thread_critsect_);
103 }; 104 };
104 105
105 } // namespace webrtc 106 } // namespace webrtc
106 107
107 #endif // WEBRTC_COMMON_VIDEO_INCLUDE_INCOMING_VIDEO_STREAM_H_ 108 #endif // WEBRTC_COMMON_VIDEO_INCLUDE_INCOMING_VIDEO_STREAM_H_
OLDNEW
« no previous file with comments | « webrtc/common_video/i420_video_frame_unittest.cc ('k') | webrtc/common_video/include/video_frame_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698