Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1738863002: Replace scoped_ptr with unique_ptr in webrtc/modules/video_*/ (Closed)

Created:
4 years, 9 months ago by kwiberg-webrtc
Modified:
4 years, 9 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, sdk-team_agora.io, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@up4
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/video_*/ BUG=webrtc:5520 Committed: https://crrev.com/e065fcf9a9bc1cdbe73e8ef01b3dad7c15585e93 Cr-Commit-Position: refs/heads/master@{#11836}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove "using" declaration #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -49 lines) Patch
M webrtc/modules/video_capture/linux/video_capture_linux.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 1 11 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/video_processing/frame_preprocessor.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/test/brightness_detection_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/test/content_metrics_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/test/deflickering_test.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/video_processing/test/denoiser_test.cc View 1 2 5 chunks +9 lines, -7 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/video_processing/util/denoiser_filter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/util/denoiser_filter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/video_denoiser.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/video_render/android/video_render_android_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_render/ios/video_render_ios_gles20.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_render/ios/video_render_ios_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/video_render/ios/video_render_ios_view.mm View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/video_render/mac/video_render_agl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_render/mac/video_render_nsopengl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_render/windows/video_render_direct3d9.h View 2 chunks +4 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1749103003 Patch 40001

Messages

Total messages: 17 (6 generated)
kwiberg-webrtc
stefan: video_processing mflodman: video_capture, video_render
4 years, 9 months ago (2016-02-25 14:32:05 UTC) #2
stefan-webrtc
lgtm after you fixed my comment. https://codereview.webrtc.org/1738863002/diff/1/webrtc/modules/video_capture/test/video_capture_unittest.cc File webrtc/modules/video_capture/test/video_capture_unittest.cc (right): https://codereview.webrtc.org/1738863002/diff/1/webrtc/modules/video_capture/test/video_capture_unittest.cc#newcode28 webrtc/modules/video_capture/test/video_capture_unittest.cc:28: using std::unique_ptr; I ...
4 years, 9 months ago (2016-02-25 14:57:33 UTC) #3
kwiberg-webrtc
No longer using. https://codereview.webrtc.org/1738863002/diff/1/webrtc/modules/video_capture/test/video_capture_unittest.cc File webrtc/modules/video_capture/test/video_capture_unittest.cc (right): https://codereview.webrtc.org/1738863002/diff/1/webrtc/modules/video_capture/test/video_capture_unittest.cc#newcode28 webrtc/modules/video_capture/test/video_capture_unittest.cc:28: using std::unique_ptr; On 2016/02/25 14:57:33, stefan-webrtc ...
4 years, 9 months ago (2016-02-27 13:14:47 UTC) #4
stefan-webrtc
lgtm
4 years, 9 months ago (2016-02-29 08:37:14 UTC) #5
kwiberg-webrtc
mflodman: ping? (video_capture, video_render) Or suggest who else I should bother with this... :-)
4 years, 9 months ago (2016-03-01 09:26:04 UTC) #6
mflodman
lgtm
4 years, 9 months ago (2016-03-01 15:23:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738863002/40001
4 years, 9 months ago (2016-03-01 17:31:58 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on ...
4 years, 9 months ago (2016-03-01 19:32:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1738863002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1738863002/40001
4 years, 9 months ago (2016-03-02 08:59:12 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 09:01:15 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 09:01:30 UTC) #17
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/e065fcf9a9bc1cdbe73e8ef01b3dad7c15585e93
Cr-Commit-Position: refs/heads/master@{#11836}

Powered by Google App Engine
This is Rietveld 408576698