[rtp_rtcp] tmmbr helper simplified by moving set_to_send member out

_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_
because in the TMMBRHelp class it is independent of other members.

BUG=webrtc:5565
R=philipel

Committed: https://crrev.com/6eaa3a41ce71df7f33b79cc011418dc7c3cf9490
Cr-Commit-Position: refs/heads/master@{#12669}

[danilchap, 2016-03-02 09:19:20]

Description was changed from

==========
_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_

Next slice of https://codereview.webrtc.org/1474693002/
boundingSetToSend in the TMMBRHelp class is independent of other members.

BUG=webrtc:5565
R=philipel, stefan-webrtc (holmer)
==========

to

==========
_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_
because in the TMMBRHelp class it is independent of other members.

BUG=webrtc:5565
R=philipel, stefan-webrtc (holmer)
==========

[philipel, 2016-03-04 10:49:27]

https://codereview.webrtc.org/1746773002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.h (right):

https://codereview.webrtc.org/1746773002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:135: void SetTMMBN(const TMMBRSet*
boundingSet);
While you are at it, change to const TMMBRSet& instead.

https://codereview.webrtc.org/1746773002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:241: std::vector<rtcp::TmmbItem>
tmmbn_to_send_
Don't you think it would be clearer to use a TMMBRSet instead of a vector here?
Even if you don't need any of the convenience functions I still think it is
better.

[danilchap, 2016-03-04 14:06:13]

https://codereview.webrtc.org/1746773002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.h (right):

https://codereview.webrtc.org/1746773002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:135: void SetTMMBN(const TMMBRSet*
boundingSet);
On 2016/03/04 10:49:27, philipel wrote:
> While you are at it, change to const TMMBRSet& instead.

Unfortunately right now caller can't guarantee non-null parameter.
So leaving this change until later CL where this guarantee would be obvious.

https://codereview.webrtc.org/1746773002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_sender.h:241: std::vector<rtcp::TmmbItem>
tmmbn_to_send_
On 2016/03/04 10:49:27, philipel wrote:
> Don't you think it would be clearer to use a TMMBRSet instead of a vector
here?
> Even if you don't need any of the convenience functions I still think it is
> better.
Yes, it is inconsistent with SetTMMBN function, but
TMMBRSet type doesn't follow type name convention and doesn't add any real
features to vector. Goal is to remove this type completely.
So, to be clearer, I've updated SetTMMBN function instead.

[philipel, 2016-03-10 11:57:38]

lgtm

[danilchap, 2016-03-14 11:59:41]

Description was changed from

==========
_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_
because in the TMMBRHelp class it is independent of other members.

BUG=webrtc:5565
R=philipel, stefan-webrtc (holmer)
==========

to

==========
_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_
because in the TMMBRHelp class it is independent of other members.

BUG=webrtc:5565
R=philipel
==========

[danilchap, 2016-03-14 11:59:41]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org
- stefan@webrtc.org

[danilchap, 2016-03-21 15:11:25]

Patchset #6 (id:100001) has been deleted

[åsapersson, 2016-05-09 15:57:11]

lgtm

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:644: for (const rtcp::TmmbItem&
timber : tmmbn_to_send_) {
maybe timber->tmmbr

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:975: if (!bounding_set) {
maybe if (bounding_set)...

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/tmmbr_help.h (left):

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/tmmbr_help.h:78: int32_t
VerifyAndAllocateBoundingSetToSend(uint32_t minimumSize);
can this be removed?

[danilchap, 2016-05-09 16:06:27]

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/rtcp_sender.cc (right):

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:644: for (const rtcp::TmmbItem&
timber : tmmbn_to_send_) {
On 2016/05/09 15:57:11, åsapersson wrote:
> maybe timber->tmmbr

Done.

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/rtcp_sender.cc:975: if (!bounding_set) {
On 2016/05/09 15:57:11, åsapersson wrote:
> maybe if (bounding_set)...

Done.

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
File webrtc/modules/rtp_rtcp/source/tmmbr_help.h (left):

https://codereview.webrtc.org/1746773002/diff/180001/webrtc/modules/rtp_rtcp/...
webrtc/modules/rtp_rtcp/source/tmmbr_help.h:78: int32_t
VerifyAndAllocateBoundingSetToSend(uint32_t minimumSize);
On 2016/05/09 15:57:11, åsapersson wrote:
> can this be removed?

oops, Removed.

[danilchap, 2016-05-09 16:32:00]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-05-09 16:32:01]

The patchset sent to the CQ was uploaded after l-g-t-m from philipel@webrtc.org,
asapersson@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1746773002/#ps200001 (title:
"feedback")

[commit-bot: I haz the power, 2016-05-09 16:32:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1746773002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1746773002/200001

[commit-bot: I haz the power, 2016-05-09 17:59:56]

Description was changed from

==========
_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_
because in the TMMBRHelp class it is independent of other members.

BUG=webrtc:5565
R=philipel
==========

to

==========
_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_
because in the TMMBRHelp class it is independent of other members.

BUG=webrtc:5565
R=philipel
==========

[commit-bot: I haz the power, 2016-05-09 17:59:57]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-05-09 17:59:59]

Description was changed from

==========
_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_
because in the TMMBRHelp class it is independent of other members.

BUG=webrtc:5565
R=philipel
==========

to

==========
_boundingSetToSend moved out of tmmbr_help_ into tmmbn_to_send_
because in the TMMBRHelp class it is independent of other members.

BUG=webrtc:5565
R=philipel

Committed: https://crrev.com/6eaa3a41ce71df7f33b79cc011418dc7c3cf9490
Cr-Commit-Position: refs/heads/master@{#12669}
==========

[commit-bot: I haz the power, 2016-05-09 18:00:00]

Patchset 10 (id:??) landed as
https://crrev.com/6eaa3a41ce71df7f33b79cc011418dc7c3cf9490
Cr-Commit-Position: refs/heads/master@{#12669}