webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc - Issue 1746773002: [rtp_rtcp] tmmbr helper simplified by moving set_to_send member out

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

Issue 1746773002: [rtp_rtcp] tmmbr helper simplified by moving set_to_send member out (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: feedback Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

diff --git a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

index 8a1e2fc36cc81120afef074612c2bc8dbd240f7c..214472f81ae3998cce8838ecca09eb40ac89d70c 100644

--- a/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

+++ b/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc

@@ -680,8 +680,9 @@ void ModuleRtpRtcpImpl::SetTMMBRStatus(const bool enable) {

rtcp_sender_.SetTMMBRStatus(enable);

}

-int32_t ModuleRtpRtcpImpl::SetTMMBN(const TMMBRSet* bounding_set) {

- return rtcp_sender_.SetTMMBN(bounding_set);

+void ModuleRtpRtcpImpl::SetTMMBN(

+ const std::vector<rtcp::TmmbItem>* bounding_set) {

+ rtcp_sender_.SetTMMBN(bounding_set);

}

// Returns the currently configured retransmission mode.

« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h ('k') | webrtc/modules/rtp_rtcp/source/tmmbr_help.h » ('j') | no next file with comments »