Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtcp_sender.h

Issue 1746773002: [rtp_rtcp] tmmbr helper simplified by moving set_to_send member out (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: feedback Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_sender.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 117 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 void SetREMBStatus(bool enable); 128 void SetREMBStatus(bool enable);
129 129
130 void SetREMBData(uint32_t bitrate, const std::vector<uint32_t>& ssrcs); 130 void SetREMBData(uint32_t bitrate, const std::vector<uint32_t>& ssrcs);
131 131
132 bool TMMBR() const; 132 bool TMMBR() const;
133 133
134 void SetTMMBRStatus(bool enable); 134 void SetTMMBRStatus(bool enable);
135 135
136 void SetMaxPayloadLength(size_t max_payload_length); 136 void SetMaxPayloadLength(size_t max_payload_length);
137 137
138 int32_t SetTMMBN(const TMMBRSet* boundingSet); 138 void SetTMMBN(const std::vector<rtcp::TmmbItem>* boundingSet);
139 139
140 int32_t SetApplicationSpecificData(uint8_t subType, 140 int32_t SetApplicationSpecificData(uint8_t subType,
141 uint32_t name, 141 uint32_t name,
142 const uint8_t* data, 142 const uint8_t* data,
143 uint16_t length); 143 uint16_t length);
144 int32_t SetRTCPVoIPMetrics(const RTCPVoIPMetric* VoIPMetric); 144 int32_t SetRTCPVoIPMetrics(const RTCPVoIPMetric* VoIPMetric);
145 145
146 void SendRtcpXrReceiverReferenceTime(bool enable); 146 void SendRtcpXrReceiverReferenceTime(bool enable);
147 147
148 bool RtcpXrReceiverReferenceTime() const; 148 bool RtcpXrReceiverReferenceTime() const;
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 std::vector<uint32_t> csrcs_ GUARDED_BY(critical_section_rtcp_sender_); 234 std::vector<uint32_t> csrcs_ GUARDED_BY(critical_section_rtcp_sender_);
235 235
236 // Full intra request 236 // Full intra request
237 uint8_t sequence_number_fir_ GUARDED_BY(critical_section_rtcp_sender_); 237 uint8_t sequence_number_fir_ GUARDED_BY(critical_section_rtcp_sender_);
238 238
239 // REMB 239 // REMB
240 uint32_t remb_bitrate_ GUARDED_BY(critical_section_rtcp_sender_); 240 uint32_t remb_bitrate_ GUARDED_BY(critical_section_rtcp_sender_);
241 std::vector<uint32_t> remb_ssrcs_ GUARDED_BY(critical_section_rtcp_sender_); 241 std::vector<uint32_t> remb_ssrcs_ GUARDED_BY(critical_section_rtcp_sender_);
242 242
243 TMMBRHelp tmmbr_help_ GUARDED_BY(critical_section_rtcp_sender_); 243 TMMBRHelp tmmbr_help_ GUARDED_BY(critical_section_rtcp_sender_);
244 std::vector<rtcp::TmmbItem> tmmbn_to_send_
245 GUARDED_BY(critical_section_rtcp_sender_);
244 uint32_t tmmbr_send_ GUARDED_BY(critical_section_rtcp_sender_); 246 uint32_t tmmbr_send_ GUARDED_BY(critical_section_rtcp_sender_);
245 uint32_t packet_oh_send_ GUARDED_BY(critical_section_rtcp_sender_); 247 uint32_t packet_oh_send_ GUARDED_BY(critical_section_rtcp_sender_);
246 size_t max_payload_length_; 248 size_t max_payload_length_;
247 249
248 // APP 250 // APP
249 uint8_t app_sub_type_ GUARDED_BY(critical_section_rtcp_sender_); 251 uint8_t app_sub_type_ GUARDED_BY(critical_section_rtcp_sender_);
250 uint32_t app_name_ GUARDED_BY(critical_section_rtcp_sender_); 252 uint32_t app_name_ GUARDED_BY(critical_section_rtcp_sender_);
251 std::unique_ptr<uint8_t[]> app_data_ 253 std::unique_ptr<uint8_t[]> app_data_
252 GUARDED_BY(critical_section_rtcp_sender_); 254 GUARDED_BY(critical_section_rtcp_sender_);
253 uint16_t app_length_ GUARDED_BY(critical_section_rtcp_sender_); 255 uint16_t app_length_ GUARDED_BY(critical_section_rtcp_sender_);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 290
289 typedef std::unique_ptr<rtcp::RtcpPacket> (RTCPSender::*BuilderFunc)( 291 typedef std::unique_ptr<rtcp::RtcpPacket> (RTCPSender::*BuilderFunc)(
290 const RtcpContext&); 292 const RtcpContext&);
291 std::map<RTCPPacketType, BuilderFunc> builders_; 293 std::map<RTCPPacketType, BuilderFunc> builders_;
292 294
293 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RTCPSender); 295 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(RTCPSender);
294 }; 296 };
295 } // namespace webrtc 297 } // namespace webrtc
296 298
297 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_SENDER_H_ 299 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTCP_SENDER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_sender.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698