Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1736663004: Revert of Remove ignored return code from modules. (Closed)

Created:
4 years, 10 months ago by torbjorng (webrtc)
Modified:
4 years, 10 months ago
Reviewers:
tommi, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, henrika_webrtc, zhengzhonghou_agora.io, Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, sdk-team_agora.io, peah-webrtc, minyue-webrtc, the sun, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove ignored return code from modules. (patchset #3 id:40001 of https://codereview.webrtc.org/1703833002/ ) Reason for revert: Breaks Chromium. Original issue's description: > Remove ignored return code from modules. > > ModuleProcessImpl doesn't act on return codes and having them around is > confusing (it's unclear what an error return code here would do even). > > BUG= > R=tommi@webrtc.org > > Committed: https://chromium.googlesource.com/external/webrtc/+/f14c47a58cb2a333cb9b11aef593f0e632fdb28a TBR=tommi@webrtc.org,pbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/da33a8a2a22f6d19ba2a8cce963beafbdbaa8fd8 Cr-Commit-Position: refs/heads/master@{#11761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -143 lines) Patch
M webrtc/api/test/fakeaudiocapturemodule.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/api/test/fakeaudiocapturemodule.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/api/test/fakeaudiocapturemodule_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/media/engine/fakewebrtcvideocapturemodule.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/include/audio_conference_mixer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_conference_mixer/source/audio_conference_mixer_impl.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M webrtc/modules/audio_conference_mixer/test/audio_conference_mixer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/include/fake_audio_device.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/include/module.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/media_file/media_file_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/mock/mock_remote_bitrate_estimator.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc View 10 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_estimator_proxy.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/bwe.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/nada.cc View 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/remb.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/include/receive_statistics.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/mocks/mock_rtp_rtcp.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/receive_statistics_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/utility/source/process_thread_impl_unittest.cc View 7 chunks +14 lines, -13 lines 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_capture/video_capture_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/test/vcm_payload_sink_factory.cc View 1 chunk +3 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_robustness_unittest.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver.cc View 4 chunks +14 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/video_receiver_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/video_sender.cc View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/modules/video_render/video_render.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/video_render_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_render/video_render_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/modules/video_render/video_render_internal_impl.cc View 1 chunk +5 lines, -1 line 0 comments Download
M webrtc/video/call_stats.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/call_stats.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/overuse_frame_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M webrtc/video/vie_sync_module.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_sync_module.cc View 5 chunks +9 lines, -8 lines 0 comments Download
M webrtc/voice_engine/monitor_module.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/voice_engine/monitor_module.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/voice_engine/output_mixer.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
torbjorng (webrtc)
Created Revert of Remove ignored return code from modules.
4 years, 10 months ago (2016-02-25 12:33:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1736663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1736663004/1
4 years, 10 months ago (2016-02-25 12:33:44 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 12:34:09 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da33a8a2a22f6d19ba2a8cce963beafbdbaa8fd8 Cr-Commit-Position: refs/heads/master@{#11761}
4 years, 10 months ago (2016-02-25 12:34:16 UTC) #5
pbos-webrtc
4 years, 10 months ago (2016-02-25 12:49:42 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1737013002/ by pbos@webrtc.org.

The reason for reverting is: Revert breaks other uses, a fix will be rolled into
Chromium instead..

Powered by Google App Engine
This is Rietveld 408576698