Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Side by Side Diff: webrtc/modules/media_file/media_file_impl.cc

Issue 1736663004: Revert of Remove ignored return code from modules. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/media_file/media_file_impl.h ('k') | webrtc/modules/pacing/paced_sender.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 int64_t MediaFileImpl::TimeUntilNextProcess() 88 int64_t MediaFileImpl::TimeUntilNextProcess()
89 { 89 {
90 WEBRTC_TRACE( 90 WEBRTC_TRACE(
91 kTraceWarning, 91 kTraceWarning,
92 kTraceFile, 92 kTraceFile,
93 _id, 93 _id,
94 "TimeUntilNextProcess: This method is not used by MediaFile class."); 94 "TimeUntilNextProcess: This method is not used by MediaFile class.");
95 return -1; 95 return -1;
96 } 96 }
97 97
98 void MediaFileImpl::Process() 98 int32_t MediaFileImpl::Process()
99 { 99 {
100 WEBRTC_TRACE(kTraceWarning, kTraceFile, _id, 100 WEBRTC_TRACE(kTraceWarning, kTraceFile, _id,
101 "Process: This method is not used by MediaFile class."); 101 "Process: This method is not used by MediaFile class.");
102 return -1;
102 } 103 }
103 104
104 int32_t MediaFileImpl::PlayoutAudioData(int8_t* buffer, 105 int32_t MediaFileImpl::PlayoutAudioData(int8_t* buffer,
105 size_t& dataLengthInBytes) 106 size_t& dataLengthInBytes)
106 { 107 {
107 WEBRTC_TRACE(kTraceStream, kTraceFile, _id, 108 WEBRTC_TRACE(kTraceStream, kTraceFile, _id,
108 "MediaFileImpl::PlayoutData(buffer= 0x%x, bufLen= %" PRIuS ")", 109 "MediaFileImpl::PlayoutData(buffer= 0x%x, bufLen= %" PRIuS ")",
109 buffer, dataLengthInBytes); 110 buffer, dataLengthInBytes);
110 111
111 const size_t bufferLengthInBytes = dataLengthInBytes; 112 const size_t bufferLengthInBytes = dataLengthInBytes;
(...skipping 1015 matching lines...) Expand 10 before | Expand all | Expand 10 after
1127 { 1128 {
1128 if((frequency == 8000) || (frequency == 16000)|| (frequency == 32000)) 1129 if((frequency == 8000) || (frequency == 16000)|| (frequency == 32000))
1129 { 1130 {
1130 return true; 1131 return true;
1131 } 1132 }
1132 WEBRTC_TRACE(kTraceError, kTraceFile, -1, 1133 WEBRTC_TRACE(kTraceError, kTraceFile, -1,
1133 "Frequency should be 8000, 16000 or 32000 (Hz)"); 1134 "Frequency should be 8000, 16000 or 32000 (Hz)");
1134 return false; 1135 return false;
1135 } 1136 }
1136 } // namespace webrtc 1137 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/media_file/media_file_impl.h ('k') | webrtc/modules/pacing/paced_sender.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698