webrtc/modules/congestion_controller/congestion_controller.cc - Issue 1736663004: Revert of Remove ignored return code from modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/congestion_controller/congestion_controller.cc

Issue 1736663004: Revert of Remove ignored return code from modules. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h ('k') | webrtc/modules/congestion_controller/include/congestion_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/congestion_controller/congestion_controller.cc

diff --git a/webrtc/modules/congestion_controller/congestion_controller.cc b/webrtc/modules/congestion_controller/congestion_controller.cc

index f9e7e018e517e1c4b1a24f8b59cf87681c27b3d8..50074d50e4477e4bf4be435755b83abda7cd4e81 100644

--- a/webrtc/modules/congestion_controller/congestion_controller.cc

+++ b/webrtc/modules/congestion_controller/congestion_controller.cc

@@ -53,9 +53,9 @@

rbe_->IncomingPacket(arrival_time_ms, payload_size, header, was_paced);

}

- void Process() override {

- CriticalSectionScoped cs(crit_sect_.get());

- rbe_->Process();

+ int32_t Process() override {

+ CriticalSectionScoped cs(crit_sect_.get());

+ return rbe_->Process();

}

int64_t TimeUntilNextProcess() override {

@@ -241,9 +241,10 @@

remote_bitrate_estimator_->TimeUntilNextProcess());

}

-void CongestionController::Process() {

+int32_t CongestionController::Process() {

bitrate_controller_->Process();

remote_bitrate_estimator_->Process();

+ return 0;

}

} // namespace webrtc