Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1715423002: Remove workaround for Opus DTX noise pumping issue. (Closed)

Created:
4 years, 10 months ago by minyue-webrtc
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove workaround for Opus DTX noise pumping issue. A workaround for Opus DTX noise pumping issue was made according upon this https://codereview.webrtc.org/1422213003 Recently, Opus has fixed this problem internally, and hence the workaround is not needed any longer. This CL removes this workaround. BUG=586175 R=flim@webrtc.org, tina.legrand@webrtc.org Committed: https://crrev.com/7e937e951ca6273d524720efc59a651fd1a0adbe Cr-Commit-Position: refs/heads/master@{#11805}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -51 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/opus_inst.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_interface.c View 4 chunks +1 line, -44 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_unittest.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 19 (12 generated)
minyue-webrtc
Hi Tina and Felicia, Please review this CL that removes the temporary solution to DTX ...
4 years, 10 months ago (2016-02-24 14:31:21 UTC) #9
flim-webrtc
lgtm
4 years, 10 months ago (2016-02-24 15:30:07 UTC) #10
tlegrand-webrtc
lgtm
4 years, 10 months ago (2016-02-26 12:14:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1715423002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1715423002/120001
4 years, 9 months ago (2016-02-29 08:51:42 UTC) #13
commit-bot: I haz the power
Exceeded global retry quota
4 years, 9 months ago (2016-02-29 09:21:23 UTC) #15
minyue-webrtc
Committed patchset #1 (id:120001) manually as 7e937e951ca6273d524720efc59a651fd1a0adbe (presubmit successful).
4 years, 9 months ago (2016-02-29 09:24:31 UTC) #17
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 09:24:36 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e937e951ca6273d524720efc59a651fd1a0adbe
Cr-Commit-Position: refs/heads/master@{#11805}

Powered by Google App Engine
This is Rietveld 408576698