Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 1422213003: Reland "Prevent Opus DTX from generating intermittent noise during silence" (Closed)

Created:
5 years, 1 month ago by minyue-webrtc
Modified:
5 years, 1 month ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, henrika_webrtc, tlegrand-webrtc, tterriberry_mozilla.com, hlundin-webrtc, peah-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland "Prevent Opus DTX from generating intermittent noise during silence" The original CL is reviewed at https://codereview.webrtc.org/1415173005/ A silly mistake was made at the last patch set, and the CL was reverted. This CL is to fix and reland it. BUG=webrtc:5127 Committed: https://crrev.com/3cea25680620f0b7df7642fc8fe49d0ecaf8b466 Cr-Commit-Position: refs/heads/master@{#10574}

Patch Set 1 : same as original CL #

Patch Set 2 : fixing #

Patch Set 3 : disable voe test on bots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -62 lines) Patch
M webrtc/modules/audio_coding/codecs/opus/opus_inst.h View 1 chunk +7 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_interface.c View 3 chunks +74 lines, -31 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_unittest.cc View 10 chunks +83 lines, -31 lines 0 comments Download
M webrtc/modules/audio_coding/main/audio_coding_module.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
A webrtc/voice_engine/test/auto_test/voe_output_test.cc View 1 2 1 chunk +203 lines, -0 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
minyue-webrtc
Hi Karl and Fredrik, I made a silly mistake in the CL that you reviewed. ...
5 years, 1 month ago (2015-11-09 23:10:57 UTC) #3
kwiberg-webrtc
Ah, the old mistake of making an odd number of sign errors... lgtm
5 years, 1 month ago (2015-11-10 02:32:15 UTC) #5
minyue-webrtc
and per offline discussion with Fredrik, we also disable the VoE test on bots.
5 years, 1 month ago (2015-11-10 09:39:43 UTC) #6
the sun
lgtm
5 years, 1 month ago (2015-11-10 10:23:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422213003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422213003/40001
5 years, 1 month ago (2015-11-10 10:24:05 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_x64_rel/builds/10372)
5 years, 1 month ago (2015-11-10 10:32:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1422213003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1422213003/40001
5 years, 1 month ago (2015-11-10 11:41:19 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-10 11:49:29 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 11:49:45 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3cea25680620f0b7df7642fc8fe49d0ecaf8b466
Cr-Commit-Position: refs/heads/master@{#10574}

Powered by Google App Engine
This is Rietveld 408576698