webrtc/modules/audio_coding/codecs/opus/opus_inst.h - Issue 1715423002: Remove workaround for Opus DTX noise pumping issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/opus/opus_inst.h

Issue 1715423002: Remove workaround for Opus DTX noise pumping issue. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/audio_coding/codecs/opus/opus_inst.h

diff --git a/webrtc/modules/audio_coding/codecs/opus/opus_inst.h b/webrtc/modules/audio_coding/codecs/opus/opus_inst.h

index 8d032baf355e29778c35ea8d45a48b7ee9d2cff4..aa79b46f04fe74ce18935fbea017cf7c62b926a6 100644

--- a/webrtc/modules/audio_coding/codecs/opus/opus_inst.h

+++ b/webrtc/modules/audio_coding/codecs/opus/opus_inst.h

@@ -19,12 +19,6 @@ struct WebRtcOpusEncInst {

OpusEncoder* encoder;

size_t channels;

int in_dtx_mode;

- // When Opus is in DTX mode, we use |zero_counts| to count consecutive zeros

- // to break long zero segment so as to prevent DTX from going wrong. We use

- // one counter for each channel. After each encoding, |zero_counts| contain

- // the remaining zeros from the last frame.

- // TODO(minyue): remove this when Opus gets an internal fix to DTX.

- size_t* zero_counts;

};

struct WebRtcOpusDecInst {

« no previous file with comments | « no previous file | webrtc/modules/audio_coding/codecs/opus/opus_interface.c » ('j') | no next file with comments »