Moved the AEC C code to be built using C++

Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the
move was made into two steps consisting of the
first two patches in this CL.

Step 1 (patch set 1):
-Changed file types to use .cc
-Changed buildfiles to use the new files
-Changed C code inclusion to properly match the changed
 file formats (removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are
 illegal in C++ to be explicit.

Step 2 (patch set 2):
-Changed all the warnings reported when uploading the CL.
-The warnings about formatting of the assembly optimized
 code were not addressed though.

BUG=webrtc:5201
Committed: https://crrev.com/8df5d4f15ba9f29c994103905e7cb7909e6ba969
Cr-Commit-Position: refs/heads/master@{#11727}

[peah-webrtc, 2016-02-19 09:10:38]

Description was changed from

==========
Moved the AEC c code to be built using C++
-Changed file types to use .cc
-Changed buildfiles and file types to use .cc
-Changed C code inclusion to properly match the changed file formats
(removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are illegal in C++ to be
explicit.



BUG=webrtc:5201
==========

to

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the 
move was made into two steps consisting of the 
first two patches in this CL.

Step 1 (patch 1)
-Changed file types to use .cc
-Changed buildfiles and file types to use .cc
-Changed C code inclusion to properly match the changed file formats
(removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are illegal in C++ to be
explicit.



BUG=webrtc:5201
==========

[peah-webrtc, 2016-02-19 09:14:13]

Description was changed from

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the 
move was made into two steps consisting of the 
first two patches in this CL.

Step 1 (patch 1)
-Changed file types to use .cc
-Changed buildfiles and file types to use .cc
-Changed C code inclusion to properly match the changed file formats
(removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are illegal in C++ to be
explicit.



BUG=webrtc:5201
==========

to

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the 
move was made into two steps consisting of the 
first two patches in this CL.

Step 1 (patch set 1):
-Changed file types to use .cc
-Changed buildfiles to use the new files
-Changed C code inclusion to properly match the changed
 file formats (removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are 
 illegal in C++ to be explicit.

Step 2 (patch set 2):
-Changed all the warnings reported when uploading the CL

BUG=webrtc:5201
==========

[peah-webrtc, 2016-02-19 09:14:23]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 09:14:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/20001

[peah-webrtc, 2016-02-19 09:15:18]

The CQ bit was unchecked by peah@webrtc.org

[peah-webrtc, 2016-02-19 09:15:48]

peah@webrtc.org changed reviewers:
+ solenberg@webrtc.org

[peah-webrtc, 2016-02-19 09:17:20]

Description was changed from

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the 
move was made into two steps consisting of the 
first two patches in this CL.

Step 1 (patch set 1):
-Changed file types to use .cc
-Changed buildfiles to use the new files
-Changed C code inclusion to properly match the changed
 file formats (removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are 
 illegal in C++ to be explicit.

Step 2 (patch set 2):
-Changed all the warnings reported when uploading the CL

BUG=webrtc:5201
==========

to

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the 
move was made into two steps consisting of the 
first two patches in this CL.

Step 1 (patch set 1):
-Changed file types to use .cc
-Changed buildfiles to use the new files
-Changed C code inclusion to properly match the changed
 file formats (removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are 
 illegal in C++ to be explicit.

Step 2 (patch set 2):
-Changed all the warnings reported when uploading the CL.
-The warnings about formatting of the assembly optimized
 code were not addressed though.

BUG=webrtc:5201
==========

[peah-webrtc, 2016-02-19 09:17:54]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 09:17:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/20001

[commit-bot: I haz the power, 2016-02-19 09:19:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 09:19:07]

Dry run: Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/11056)
  linux_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/8707)
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3539)

[peah-webrtc, 2016-02-19 10:29:47]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-19 10:29:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/40001

[commit-bot: I haz the power, 2016-02-19 10:36:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-19 10:36:37]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3544)

[peah-webrtc, 2016-02-19 11:52:54]

Patchset #3 (id:40001) has been deleted

[peah-webrtc, 2016-02-19 11:57:02]

The current CL is dependent upon the CL
https://codereview.webrtc.org/1710083006/
in order to be possible to land, as the current
CL exposes previously suppressed clang warnings 
in wav_file.h.
wav_file.* is changed in the aforementioned
CL such that those warnings disappear.

That CL does, however, not in any way change any
of the files included in this CL.

[peah-webrtc, 2016-02-22 10:41:04]

On 2016/02/19 11:57:02, peah-webrtc wrote:
> The current CL is dependent upon the CL
> https://codereview.webrtc.org/1710083006/
> in order to be possible to land, as the current
> CL exposes previously suppressed clang warnings 
> in wav_file.h.
> wav_file.* is changed in the aforementioned
> CL such that those warnings disappear.
> 
> That CL does, however, not in any way change any
> of the files included in this CL.

The aforementioned CL (https://codereview.webrtc.org/1710083006/)
has now been landed and is no longer something that stops the landing 
of this CL.

[the sun, 2016-02-22 20:08:09]

On 2016/02/22 10:41:04, peah-webrtc wrote:
> On 2016/02/19 11:57:02, peah-webrtc wrote:
> > The current CL is dependent upon the CL
> > https://codereview.webrtc.org/1710083006/
> > in order to be possible to land, as the current
> > CL exposes previously suppressed clang warnings 
> > in wav_file.h.
> > wav_file.* is changed in the aforementioned
> > CL such that those warnings disappear.
> > 
> > That CL does, however, not in any way change any
> > of the files included in this CL.
> 
> The aforementioned CL (https://codereview.webrtc.org/1710083006/)
> has now been landed and is no longer something that stops the landing 
> of this CL.

LGTM

[the sun, 2016-02-22 20:08:28]

https://codereview.webrtc.org/1713923002/diff/20001/webrtc/modules/audio_proc...
File webrtc/modules/audio_processing/audio_processing.gypi (right):

https://codereview.webrtc.org/1713923002/diff/20001/webrtc/modules/audio_proc...
webrtc/modules/audio_processing/audio_processing.gypi:38: 'aec/aec_rdft.c',
aec_rdft.c, aec_resampler.c will be updated later?

[peah-webrtc, 2016-02-22 22:43:12]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-22 22:43:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/20001

[commit-bot: I haz the power, 2016-02-22 22:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 22:44:25]

Dry run: Try jobs failed on following builders:
  android_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/8914)
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/5322)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/7567)
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/12834)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/11475)
  linux_compile_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_compile_dbg/build...)
  linux_ubsan_vptr on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/12883)

[peah-webrtc, 2016-02-23 05:49:32]

On 2016/02/22 20:08:28, the sun wrote:
>
https://codereview.webrtc.org/1713923002/diff/20001/webrtc/modules/audio_proc...
> File webrtc/modules/audio_processing/audio_processing.gypi (right):
> 
>
https://codereview.webrtc.org/1713923002/diff/20001/webrtc/modules/audio_proc...
> webrtc/modules/audio_processing/audio_processing.gypi:38: 'aec/aec_rdft.c',
> aec_rdft.c, aec_resampler.c will be updated later?

Yes, definitely, lets discuss how to best do that.

[peah-webrtc, 2016-02-23 05:49:41]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 05:49:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/60001

[commit-bot: I haz the power, 2016-02-23 05:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 05:51:11]

Dry run: Try jobs failed on following builders:
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/5335)
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/7663)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/7581)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/11490)

[peah-webrtc, 2016-02-23 05:57:14]

Patchset #3 (id:60001) has been deleted

[peah-webrtc, 2016-02-23 06:02:53]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 06:02:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/80001

[commit-bot: I haz the power, 2016-02-23 06:04:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 06:04:18]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3600)

[peah-webrtc, 2016-02-23 06:26:43]

Patchset #3 (id:80001) has been deleted

[peah-webrtc, 2016-02-23 07:27:30]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 07:27:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/100001

[commit-bot: I haz the power, 2016-02-23 07:29:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 07:29:54]

Dry run: Try jobs failed on following builders:
  ios_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/12851)

[peah-webrtc, 2016-02-23 09:13:30]

The CQ bit was checked by peah@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-23 09:13:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/100001

[commit-bot: I haz the power, 2016-02-23 09:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 09:19:31]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3606)

[peah-webrtc, 2016-02-23 09:21:09]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-02-23 09:21:09]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1713923002/#ps100001 (title:
"Merge with latest master")

[commit-bot: I haz the power, 2016-02-23 09:21:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/100001

[commit-bot: I haz the power, 2016-02-23 09:23:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 09:23:39]

Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3609)

[peah-webrtc, 2016-02-23 10:33:00]

The CQ bit was checked by peah@webrtc.org

[peah-webrtc, 2016-02-23 10:33:00]

The patchset sent to the CQ was uploaded after l-g-t-m from solenberg@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1713923002/#ps120001 (title:
"Format changes to comply with lint")

[commit-bot: I haz the power, 2016-02-23 10:33:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/120001

[commit-bot: I haz the power, 2016-02-23 12:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 12:33:35]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[peah-webrtc, 2016-02-23 12:45:44]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-02-23 12:45:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/120001

[commit-bot: I haz the power, 2016-02-23 14:46:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-23 14:46:29]

Try jobs failed on following builders:
  mac_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[peah-webrtc, 2016-02-23 22:06:29]

The CQ bit was checked by peah@webrtc.org

[commit-bot: I haz the power, 2016-02-23 22:06:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1713923002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1713923002/120001

[commit-bot: I haz the power, 2016-02-23 22:35:02]

Description was changed from

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the 
move was made into two steps consisting of the 
first two patches in this CL.

Step 1 (patch set 1):
-Changed file types to use .cc
-Changed buildfiles to use the new files
-Changed C code inclusion to properly match the changed
 file formats (removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are 
 illegal in C++ to be explicit.

Step 2 (patch set 2):
-Changed all the warnings reported when uploading the CL.
-The warnings about formatting of the assembly optimized
 code were not addressed though.

BUG=webrtc:5201
==========

to

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the 
move was made into two steps consisting of the 
first two patches in this CL.

Step 1 (patch set 1):
-Changed file types to use .cc
-Changed buildfiles to use the new files
-Changed C code inclusion to properly match the changed
 file formats (removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are 
 illegal in C++ to be explicit.

Step 2 (patch set 2):
-Changed all the warnings reported when uploading the CL.
-The warnings about formatting of the assembly optimized
 code were not addressed though.

BUG=webrtc:5201
==========

[commit-bot: I haz the power, 2016-02-23 22:35:04]

Committed patchset #4 (id:120001)

[commit-bot: I haz the power, 2016-02-23 22:35:09]

Description was changed from

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the 
move was made into two steps consisting of the 
first two patches in this CL.

Step 1 (patch set 1):
-Changed file types to use .cc
-Changed buildfiles to use the new files
-Changed C code inclusion to properly match the changed
 file formats (removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are 
 illegal in C++ to be explicit.

Step 2 (patch set 2):
-Changed all the warnings reported when uploading the CL.
-The warnings about formatting of the assembly optimized
 code were not addressed though.

BUG=webrtc:5201
==========

to

==========
Moved the AEC C code to be built using C++.
In order for the change to be reviewable, the
move was made into two steps consisting of the
first two patches in this CL.

Step 1 (patch set 1):
-Changed file types to use .cc
-Changed buildfiles to use the new files
-Changed C code inclusion to properly match the changed
 file formats (removed and added extern "C" declarations).
-Changed implicit void-> nonvoid casts that are
 illegal in C++ to be explicit.

Step 2 (patch set 2):
-Changed all the warnings reported when uploading the CL.
-The warnings about formatting of the assembly optimized
 code were not addressed though.

BUG=webrtc:5201

Committed: https://crrev.com/8df5d4f15ba9f29c994103905e7cb7909e6ba969
Cr-Commit-Position: refs/heads/master@{#11727}
==========

[commit-bot: I haz the power, 2016-02-23 22:35:11]

Patchset 4 (id:??) landed as
https://crrev.com/8df5d4f15ba9f29c994103905e7cb7909e6ba969
Cr-Commit-Position: refs/heads/master@{#11727}