Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1697823002: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/neteq/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@up-codecs
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/neteq/ BUG=webrtc:5520 Committed: https://crrev.com/2d0c33277c50b8ec9c0e9de0af89845c5d1389a7 Cr-Commit-Position: refs/heads/master@{#11616}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -149 lines) Patch
M webrtc/modules/audio_coding/neteq/audio_classifier.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_classifier_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_decoder_unittest.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_vector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/audio_vector.cc View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/background_noise.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/expand.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/merge.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/nack.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/nack_unittest.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_external_decoder_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 4 chunks +27 lines, -27 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_network_stats_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_stereo_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/normal_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/payload_splitter_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/audio_classifier_test.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_ilbc_quality_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/time_stretch.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/time_stretch_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/audio_loop.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_external_decoder_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/neteq_rtpplay.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/packet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/packet.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/resample_input_audio_file.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtc_event_log_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtp_analyze.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtp_file_source.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtp_file_source.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/tools/rtpcat.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1696853004 Patch 1

Dependent Patchsets:

Issue 1695763004 Patch 1

Messages

Total messages: 12 (6 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-13 17:28:58 UTC) #4
tommi
lgtm
4 years, 10 months ago (2016-02-14 15:54:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697823002/20001
4 years, 10 months ago (2016-02-14 16:10:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 10 months ago (2016-02-14 17:28:38 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2d0c33277c50b8ec9c0e9de0af89845c5d1389a7 Cr-Commit-Position: refs/heads/master@{#11616}
4 years, 10 months ago (2016-02-14 17:28:47 UTC) #11
hlundin-webrtc
4 years, 10 months ago (2016-02-15 12:29:30 UTC) #12
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698