Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1695763004: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/test/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@up-neteq
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/test/ BUG=webrtc:5520 Committed: https://crrev.com/3747838afb857104fc371c36bdfa34f62ec7bed6 Cr-Commit-Position: refs/heads/master@{#11618}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -49 lines) Patch
M webrtc/modules/audio_coding/test/APITest.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/EncodeDecodeTest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/PacketLossTest.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/PacketLossTest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/SpatialAudio.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/test/TestAllCodecs.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/TestRedFec.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/TestStereo.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/TestVADDTX.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/test/TwoWayCommunication.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/test/TwoWayCommunication.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/test/delay_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/iSACTest.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/audio_coding/test/insert_packet_with_timing.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/test/opus_test.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/test/target_delay_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1697823002 Patch 20001

Dependent Patchsets:

Issue 1694073002 Patch 1

Messages

Total messages: 11 (5 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-13 17:29:49 UTC) #3
tommi
lgtm
4 years, 10 months ago (2016-02-14 15:57:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695763004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695763004/1
4 years, 10 months ago (2016-02-15 03:12:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 04:41:01 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3747838afb857104fc371c36bdfa34f62ec7bed6 Cr-Commit-Position: refs/heads/master@{#11618}
4 years, 10 months ago (2016-02-15 04:41:15 UTC) #10
hlundin-webrtc
4 years, 10 months ago (2016-02-15 12:26:09 UTC) #11
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698