Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/

BUG=webrtc:5520
Committed: https://crrev.com/16c5a96630d8e1b8cc7123df9fc2adc874b43e0a
Cr-Commit-Position: refs/heads/master@{#11622}

[kwiberg-webrtc, 2016-02-13 17:30:28]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/

BUG=webrtc:5520
==========

[kwiberg-webrtc, 2016-02-13 17:30:28]

kwiberg@webrtc.org changed reviewers:
+ henrik.lundin@webrtc.org, pthatcher@webrtc.org, tommi@webrtc.org

[tommi, 2016-02-14 15:56:13]

lgtm

[kwiberg-webrtc, 2016-02-15 09:21:05]

The CQ bit was checked by kwiberg@webrtc.org

[commit-bot: I haz the power, 2016-02-15 09:21:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694073002/1

[commit-bot: I haz the power, 2016-02-15 10:27:27]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/

BUG=webrtc:5520
==========

[commit-bot: I haz the power, 2016-02-15 10:27:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-02-15 10:27:37]

Description was changed from

==========
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/

BUG=webrtc:5520
==========

to

==========
Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/

BUG=webrtc:5520

Committed: https://crrev.com/16c5a96630d8e1b8cc7123df9fc2adc874b43e0a
Cr-Commit-Position: refs/heads/master@{#11622}
==========

[commit-bot: I haz the power, 2016-02-15 10:27:40]

Patchset 1 (id:??) landed as
https://crrev.com/16c5a96630d8e1b8cc7123df9fc2adc874b43e0a
Cr-Commit-Position: refs/heads/master@{#11622}

[hlundin-webrtc, 2016-02-15 11:18:15]

lgtm, but...

https://codereview.webrtc.org/1694073002/diff/1/webrtc/modules/audio_coding/a...
File webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc (right):

https://codereview.webrtc.org/1694073002/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc:16: #include
<memory>
You do not have to repeat the same include in both .h and .cc files.

https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
"any includes present in the related header do not need to be included again in
the related cc (i.e., foo.cc can rely on foo.h's includes)."

[kwiberg-webrtc, 2016-02-15 11:42:50]

https://codereview.webrtc.org/1694073002/diff/1/webrtc/modules/audio_coding/a...
File webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc (right):

https://codereview.webrtc.org/1694073002/diff/1/webrtc/modules/audio_coding/a...
webrtc/modules/audio_coding/acm2/acm_receive_test_oldapi.cc:16: #include
<memory>
On 2016/02/15 11:18:15, hlundin-webrtc wrote:
> You do not have to repeat the same include in both .h and .cc files.
> 
> https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
> "any includes present in the related header do not need to be included again
in
> the related cc (i.e., foo.cc can rely on foo.h's includes)."

Yeah, the script I whipped up for automating this simply ensures that we
#include <memory> in all files that mention unique_ptr, without taking
subtleties like this one into account. I'll see if I can make it handle this
case without spending too much time on it.