Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1696853004: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/codecs/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_coding/codecs/ BUG=webrtc:5520 Committed: https://crrev.com/91d9756bc6b8c2a868c963e773352a8ab759e2dd Cr-Commit-Position: refs/heads/master@{#11613}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M webrtc/common_audio/vad/include/vad.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/common_audio/vad/vad.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 3 chunks +6 lines, -4 lines 2 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/isac/locked_bandwidth_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_fec_test.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/opus_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/pcm16b/audio_encoder_pcm16b.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/tools/audio_codec_speed_test.h View 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-13 17:28:12 UTC) #3
tommi
lgtm https://codereview.webrtc.org/1696853004/diff/1/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc File webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc (right): https://codereview.webrtc.org/1696853004/diff/1/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc#newcode28 webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc:28: RTC_CHECK_EQ(0, WebRtcCng_CreateEnc(&ci)); I wish unique_ptr had better support ...
4 years, 10 months ago (2016-02-14 09:08:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696853004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696853004/1
4 years, 10 months ago (2016-02-14 09:08:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-14 09:10:07 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/91d9756bc6b8c2a868c963e773352a8ab759e2dd Cr-Commit-Position: refs/heads/master@{#11613}
4 years, 10 months ago (2016-02-14 09:10:17 UTC) #10
kwiberg-webrtc
https://codereview.webrtc.org/1696853004/diff/1/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc File webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc (right): https://codereview.webrtc.org/1696853004/diff/1/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc#newcode28 webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc:28: RTC_CHECK_EQ(0, WebRtcCng_CreateEnc(&ci)); On 2016/02/14 09:08:37, tommi-webrtc wrote: > I ...
4 years, 10 months ago (2016-02-14 13:07:44 UTC) #11
hlundin-webrtc
4 years, 10 months ago (2016-02-15 12:33:23 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698