Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: webrtc/webrtc.gyp

Issue 1678763002: Re-add target in webrtc/libjingle that was dead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Disable -Wnon-virtual-dtor Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« webrtc/libjingle/xmpp/xmpp.gyp ('K') | « webrtc/libjingle/xmpp/xmpp.gyp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/webrtc.gyp
diff --git a/webrtc/webrtc.gyp b/webrtc/webrtc.gyp
index 974ad9231b85cb3eb2256eff2299a1e9d2b1da6f..1e92b5d48cc6205bf74c0cafe35df8f265caf0ac 100644
--- a/webrtc/webrtc.gyp
+++ b/webrtc/webrtc.gyp
@@ -61,6 +61,8 @@
'common.gyp:*',
'common_audio/common_audio.gyp:*',
'common_video/common_video.gyp:*',
+ 'libjingle/xmllite/xmllite.gyp:*',
+ 'libjingle/xmpp/xmpp.gyp:*',
pthatcher1 2016/02/08 19:11:47 We shouldn't compile these into webrtc. They are
kjellander_webrtc 2016/02/08 19:43:21 If they're only used by Chromium, I think we shoul
pthatcher 2016/02/08 19:50:04 I'd love it if you moved them into Chromium. We t
kjellander_webrtc 2016/02/15 18:27:54 sergeyu: if I take care of moving this to Chromium
Sergey Ulanov 2016/02/16 20:24:35 Sent a separate e-mail about it with more details.
'media/media.gyp:*',
'modules/modules.gyp:*',
'p2p/p2p.gyp:*',
« webrtc/libjingle/xmpp/xmpp.gyp ('K') | « webrtc/libjingle/xmpp/xmpp.gyp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698