Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: webrtc/libjingle/xmpp/xmpp.gyp

Issue 1678763002: Re-add target in webrtc/libjingle that was dead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Disable -Wnon-virtual-dtor Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/libjingle/xmpp/xmpp.gyp
diff --git a/webrtc/libjingle/xmpp/xmpp.gyp b/webrtc/libjingle/xmpp/xmpp.gyp
index 6b738e7f3cfbd9aa7564bc7a77df95767ab939e1..ed0cc9ac16c2f2baf17368dfd93b0bb81406a806 100644
--- a/webrtc/libjingle/xmpp/xmpp.gyp
+++ b/webrtc/libjingle/xmpp/xmpp.gyp
@@ -140,6 +140,28 @@
],
}],
],
- }],
+ }, # target rtc_xmpp
+ {
+ 'target_name': 'libjingle_xmpphelp',
+ 'type': 'static_library',
+ 'dependencies': [
+ '<(webrtc_root)/../talk/libjingle.gyp:libjingle_p2p',
+ ],
+ 'conditions': [
+ ['build_expat==1', {
+ 'dependencies': [
+ '<(DEPTH)/third_party/expat/expat.gyp:expat',
+ ],
+ }],
+ ],
+ 'sources': [
+ 'jingleinfotask.cc',
+ 'jingleinfotask.h',
+ ],
+ 'cflags_cc!': [
+ '-Wnon-virtual-dtor',
+ ],
+ }, # target libjingle_xmpphelp
+ ],
pthatcher1 2016/02/08 19:11:47 We can just delete this (and jinglinfotask.*). It
kjellander_webrtc 2016/02/08 19:43:20 I'll be happy to delete. Found this though https:/
pthatcher 2016/02/08 19:50:03 Oh wow, yes. Please delete that, too.
}
« no previous file with comments | « webrtc/libjingle/libjingle.gyp ('k') | webrtc/webrtc.gyp » ('j') | webrtc/webrtc.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698