Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: webrtc/libjingle/xmpp/xmpp.gyp

Issue 1678763002: Re-add target in webrtc/libjingle that was dead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Disable -Wnon-virtual-dtor Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 { 9 {
10 'includes': [ '../../build/common.gypi', ], 10 'includes': [ '../../build/common.gypi', ],
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 }, 133 },
134 } 134 }
135 }], 135 }],
136 ['OS=="android"', { 136 ['OS=="android"', {
137 'cflags!': [ 137 'cflags!': [
138 '-Wextra', 138 '-Wextra',
139 '-Wall', 139 '-Wall',
140 ], 140 ],
141 }], 141 }],
142 ], 142 ],
143 }], 143 }, # target rtc_xmpp
144 {
145 'target_name': 'libjingle_xmpphelp',
146 'type': 'static_library',
147 'dependencies': [
148 '<(webrtc_root)/../talk/libjingle.gyp:libjingle_p2p',
149 ],
150 'conditions': [
151 ['build_expat==1', {
152 'dependencies': [
153 '<(DEPTH)/third_party/expat/expat.gyp:expat',
154 ],
155 }],
156 ],
157 'sources': [
158 'jingleinfotask.cc',
159 'jingleinfotask.h',
160 ],
161 'cflags_cc!': [
162 '-Wnon-virtual-dtor',
163 ],
164 }, # target libjingle_xmpphelp
165 ],
pthatcher1 2016/02/08 19:11:47 We can just delete this (and jinglinfotask.*). It
kjellander_webrtc 2016/02/08 19:43:20 I'll be happy to delete. Found this though https:/
pthatcher 2016/02/08 19:50:03 Oh wow, yes. Please delete that, too.
144 } 166 }
145 167
OLDNEW
« no previous file with comments | « webrtc/libjingle/libjingle.gyp ('k') | webrtc/webrtc.gyp » ('j') | webrtc/webrtc.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698