Re-add target in webrtc/libjingle that was dead.

webrtc/webrtc.gyp

 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 {
   'conditions': [
     ['include_tests==1', {
@@ skipping 43 matching lines @@
     'call/webrtc_call.gypi',
     'video/webrtc_video.gypi',
   ],
   'variables': {
     'webrtc_all_dependencies': [
       'base/base.gyp:*',
       'sound/sound.gyp:*',
       'common.gyp:*',
       'common_audio/common_audio.gyp:*',
       'common_video/common_video.gyp:*',
+      'libjingle/xmllite/xmllite.gyp:*',
+      'libjingle/xmpp/xmpp.gyp:*',

[pthatcher1, 2016/02/08 19:11:47]

We shouldn't compile these into webrtc.  They are only used by parts of Chrome,
and only left in our repository as a convenience to them.  We should leave them
out our main build.

For reference, they are used by:

//src/jingle/glue/
//src/jingle/notifier/
//src/remoting/

If those three stop using it, we can remove them altogether.

[kjellander_webrtc, 2016/02/08 19:43:21]

If they're only used by Chromium, I think we should move the source into
Chromium's src repo instead.
If we have them in our repo but don't build them, it's possible a future Clang
update introduces a new warning which makes them start fail to compile in
Chromium. Then that'll require someone to create a WebRTC CL and land (with our
trybots being useless since they don't even build the source) + wait for a roll
to go in and so on. Quite not how it should work.

I'd say we either build the code or move the source files into Chromium. Sounds
reasonable?

[pthatcher, 2016/02/08 19:50:04]

I'd love it if you moved them into Chromium.  We talked to the remoting team
about doing that (I believe the volunteered to own it), but it's never been a
high priority for either one of us.  If you can talk to sergeyu@ and figure out
a better home, that would be great.

[kjellander_webrtc, 2016/02/15 18:27:54]

sergeyu: if I take care of moving this to Chromium, can remoting commit to own
the code? I really don't like the fact of having code in WebRTC that isn't built
as part of our CI.

[Sergey Ulanov, 2016/02/16 20:24:35]

Sent a separate e-mail about it with more details. Yes, please move xmpp and
xmllite to jingle/xmpp and jingle/xmllite. 

       'media/media.gyp:*',
       'modules/modules.gyp:*',
       'p2p/p2p.gyp:*',
       'system_wrappers/system_wrappers.gyp:*',
       'tools/tools.gyp:*',
       'voice_engine/voice_engine.gyp:*',
       '<(webrtc_vp8_dir)/vp8.gyp:*',
       '<(webrtc_vp9_dir)/vp9.gyp:*',
     ],
   },
@@ skipping 81 matching lines @@
           ],
           'defines': [
             'ENABLE_RTC_EVENT_LOG',
           ],
         }],
       ],
     },
 
   ],
 }