Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 1677623002: Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. (Closed)

Created:
4 years, 10 months ago by hbos
Modified:
4 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. (patchset #1 id:1 of https://codereview.webrtc.org/1660403004/ ) Reason for revert: Trybots red? Don't have time to intvestigate Original issue's description: > Default build flag |rtc_use_h264| to |proprietary_codecs| > if not on Android/iOS. > > This means proprietary_codecs=1 && ffmpeg_branding=Chrome > can be used to enable this H.264 enc/dec implementation > instead of rtc_use_h264=1 && ffmpeg_branding=Chrome. > This is used by both Chromium trybots (but not default > Chromium build) and offical Chrome build, meaning we will > be able to test and enable H.264 in chromium. > > This change would otherwise be enough to launch this > feature in Chrome, but because we do not want to do that > before we have chromium browser tests and are ready to flip > the switch, this CL prevents chromium from using H.264 just > yet: https://codereview.chromium.org/1641163002/ (landing > this after that CL). > > BUG=chromium:500605, chromium:468365 > > Committed: https://crrev.com/7cd94f66ebfe5bf808d7dcb8da069d35f4a2b31a > Cr-Commit-Position: refs/heads/master@{#11506} TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:500605, chromium:468365 Committed: https://crrev.com/c09525a547ec1688fcd023ffc13a95115c63f884 Cr-Commit-Position: refs/heads/master@{#11508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -21 lines) Patch
M webrtc/build/common.gypi View 1 chunk +10 lines, -14 lines 0 comments Download
M webrtc/build/webrtc.gni View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hbos
Created Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS.
4 years, 10 months ago (2016-02-05 19:02:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1677623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1677623002/1
4 years, 10 months ago (2016-02-05 19:02:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-05 19:02:46 UTC) #3
commit-bot: I haz the power
4 years, 10 months ago (2016-02-05 19:02:51 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c09525a547ec1688fcd023ffc13a95115c63f884
Cr-Commit-Position: refs/heads/master@{#11508}

Powered by Google App Engine
This is Rietveld 408576698