Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: webrtc/build/common.gypi

Issue 1677623002: Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/build/webrtc.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 # This file contains common settings for building WebRTC components. 9 # This file contains common settings for building WebRTC components.
10 10
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 # enable schannel on windows. 130 # enable schannel on windows.
131 'use_legacy_ssl_defaults%': 0, 131 'use_legacy_ssl_defaults%': 0,
132 132
133 # Determines whether NEON code will be built. 133 # Determines whether NEON code will be built.
134 'build_with_neon%': 0, 134 'build_with_neon%': 0,
135 135
136 # Enable this to use HW H.264 encoder/decoder on iOS/Mac PeerConnections. 136 # Enable this to use HW H.264 encoder/decoder on iOS/Mac PeerConnections.
137 # Enabling this may break interop with Android clients that support H264. 137 # Enabling this may break interop with Android clients that support H264.
138 'use_objc_h264%': 0, 138 'use_objc_h264%': 0,
139 139
140 # Enable this to build OpenH264 encoder/FFmpeg decoder. This is supported on
141 # all platforms except iOS. Because FFmpeg can be built with/without H.264
142 # support, |ffmpeg_branding| has to separately be set to a value that
143 # includes H.264, for example "Chrome". If FFmpeg is built without H.264,
144 # compilation succeeds but |H264DecoderImpl| fails to initialize.
145 # See also: |rtc_initialize_ffmpeg|.
146 # CHECK THE OPENH264, FFMPEG AND H.264 LICENSES/PATENTS BEFORE BUILDING.
147 # http://www.openh264.org, https://www.ffmpeg.org/
148 'rtc_use_h264%': 0,
149
140 'conditions': [ 150 'conditions': [
141 # Enable this to build OpenH264 encoder/FFmpeg decoder. This is supported
142 # on all platforms except Android and iOS. Because FFmpeg can be built
143 # with/without H.264 support, |ffmpeg_branding| has to separately be set
144 # to a value that includes H.264, for example "Chrome". If FFmpeg is built
145 # without H.264, compilation succeeds but |H264DecoderImpl| fails to
146 # initialize. See also: |rtc_initialize_ffmpeg|.
147 # CHECK THE OPENH264, FFMPEG AND H.264 LICENSES/PATENTS BEFORE BUILDING.
148 # http://www.openh264.org, https://www.ffmpeg.org/
149 ['proprietary_codecs==1 and OS!="android" and OS!="ios"', {
150 'rtc_use_h264%': 1,
151 }, {
152 'rtc_use_h264%': 0,
153 }],
154
155 # FFmpeg must be initialized for |H264DecoderImpl| to work. This can be 151 # FFmpeg must be initialized for |H264DecoderImpl| to work. This can be
156 # done by WebRTC during |H264DecoderImpl::InitDecode| or externally. 152 # done by WebRTC during |H264DecoderImpl::InitDecode| or externally.
157 # FFmpeg must only be initialized once. Projects that initialize FFmpeg 153 # FFmpeg must only be initialized once. Projects that initialize FFmpeg
158 # externally, such as Chromium, must turn this flag off so that WebRTC 154 # externally, such as Chromium, must turn this flag off so that WebRTC
159 # does not also initialize. 155 # does not also initialize.
160 ['build_with_chromium==0', { 156 ['build_with_chromium==0', {
161 'rtc_initialize_ffmpeg%': 1, 157 'rtc_initialize_ffmpeg%': 1,
162 }, { 158 }, {
163 'rtc_initialize_ffmpeg%': 0, 159 'rtc_initialize_ffmpeg%': 0,
164 }], 160 }],
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 # of a more specific macro. 474 # of a more specific macro.
479 'defines': [ 475 'defines': [
480 'WEBRTC_POSIX', 476 'WEBRTC_POSIX',
481 ], 477 ],
482 }], 478 }],
483 ], 479 ],
484 }, 480 },
485 }, # target_defaults 481 }, # target_defaults
486 } 482 }
487 483
OLDNEW
« no previous file with comments | « no previous file | webrtc/build/webrtc.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698