Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Side by Side Diff: webrtc/build/webrtc.gni

Issue 1677623002: Revert of Default build flag |rtc_use_h264| to |proprietary_codecs| if not on Android/iOS. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/config/arm.gni") 9 import("//build/config/arm.gni")
10 import("//build/config/features.gni")
11 import("//build/config/mips.gni") 10 import("//build/config/mips.gni")
12 import("//build_overrides/webrtc.gni") 11 import("//build_overrides/webrtc.gni")
13 12
14 declare_args() { 13 declare_args() {
15 build_with_libjingle = true 14 build_with_libjingle = true
16 15
17 # Disable this to avoid building the Opus audio codec. 16 # Disable this to avoid building the Opus audio codec.
18 rtc_include_opus = true 17 rtc_include_opus = true
19 18
20 # Used to specify an external Jsoncpp include path when not compiling the 19 # Used to specify an external Jsoncpp include path when not compiling the
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 # Determines whether NEON code will be built. 85 # Determines whether NEON code will be built.
87 rtc_build_with_neon = 86 rtc_build_with_neon =
88 (current_cpu == "arm" && (arm_use_neon || arm_optionally_use_neon)) || 87 (current_cpu == "arm" && (arm_use_neon || arm_optionally_use_neon)) ||
89 current_cpu == "arm64" 88 current_cpu == "arm64"
90 89
91 # Enable this to use HW H.264 encoder/decoder on iOS PeerConnections. 90 # Enable this to use HW H.264 encoder/decoder on iOS PeerConnections.
92 # Enabling this may break interop with Android clients that support H264. 91 # Enabling this may break interop with Android clients that support H264.
93 rtc_use_objc_h264 = false 92 rtc_use_objc_h264 = false
94 93
95 # Enable this to build OpenH264 encoder/FFmpeg decoder. This is supported on 94 # Enable this to build OpenH264 encoder/FFmpeg decoder. This is supported on
96 # all platforms except Android and iOS. Because FFmpeg can be built 95 # all platforms except iOS. Because FFmpeg can be built with/without H.264
97 # with/without H.264 support, |ffmpeg_branding| has to separately be set to a 96 # support, |ffmpeg_branding| has to separately be set to a value that
98 # value that includes H.264, for example "Chrome". If FFmpeg is built without 97 # includes H.264, for example "Chrome". If FFmpeg is built without H.264,
99 # H.264, compilation succeeds but |H264DecoderImpl| fails to initialize. See 98 # compilation succeeds but |H264DecoderImpl| fails to initialize.
100 # also: |rtc_initialize_ffmpeg|. 99 # See also: |rtc_initialize_ffmpeg|.
101 # CHECK THE OPENH264, FFMPEG AND H.264 LICENSES/PATENTS BEFORE BUILDING. 100 # CHECK THE OPENH264, FFMPEG AND H.264 LICENSES/PATENTS BEFORE BUILDING.
102 # http://www.openh264.org, https://www.ffmpeg.org/ 101 # http://www.openh264.org, https://www.ffmpeg.org/
103 rtc_use_h264 = proprietary_codecs && !is_android && !is_ios 102 rtc_use_h264 = false
104 103
105 # FFmpeg must be initialized for |H264DecoderImpl| to work. This can be done 104 # FFmpeg must be initialized for |H264DecoderImpl| to work. This can be done
106 # by WebRTC during |H264DecoderImpl::InitDecode| or externally. FFmpeg must 105 # by WebRTC during |H264DecoderImpl::InitDecode| or externally. FFmpeg must
107 # only be initialized once. Projects that initialize FFmpeg externally, such 106 # only be initialized once. Projects that initialize FFmpeg externally, such
108 # as Chromium, must turn this flag off so that WebRTC does not also 107 # as Chromium, must turn this flag off so that WebRTC does not also
109 # initialize. 108 # initialize.
110 rtc_initialize_ffmpeg = !build_with_chromium 109 rtc_initialize_ffmpeg = !build_with_chromium
111 } 110 }
112 111
113 # A second declare_args block, so that declarations within it can 112 # A second declare_args block, so that declarations within it can
114 # depend on the possibly overridden variables in the first 113 # depend on the possibly overridden variables in the first
115 # declare_args block. 114 # declare_args block.
116 declare_args() { 115 declare_args() {
117 # Include the iLBC audio codec? 116 # Include the iLBC audio codec?
118 rtc_include_ilbc = !(build_with_chromium || build_with_mozilla) 117 rtc_include_ilbc = !(build_with_chromium || build_with_mozilla)
119 } 118 }
120 119
121 # Make it possible to provide custom locations for some libraries (move these 120 # Make it possible to provide custom locations for some libraries (move these
122 # up into declare_args should we need to actually use them for the GN build). 121 # up into declare_args should we need to actually use them for the GN build).
123 rtc_libvpx_dir = "//third_party/libvpx_new" 122 rtc_libvpx_dir = "//third_party/libvpx_new"
124 rtc_libyuv_dir = "//third_party/libyuv" 123 rtc_libyuv_dir = "//third_party/libyuv"
125 rtc_opus_dir = "//third_party/opus" 124 rtc_opus_dir = "//third_party/opus"
OLDNEW
« no previous file with comments | « webrtc/build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698