Initialize VideoSendStream members in constructor.

Initialize VideoSendStream members in constructor.

Removes scoped_ptrs and provides clearer lifetime between objects.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed: https://crrev.com/8c66a00a377ac25d732e7c99c90d65b15553c304
Cr-Commit-Position: refs/heads/master@{#11571}

[pbos-webrtc, 2016-02-05 15:33:59]

PTAL

[pbos-webrtc, 2016-02-08 13:10:19]

rebase

[stefan-webrtc, 2016-02-11 10:15:40]

looks good in general, but please consider these suggestions

https://codereview.webrtc.org/1674663002/diff/20001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1674663002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream.cc:161: GetTransportFeedbackObserver(),
I'd prefer if this is done as in audio_send_stream.cc instead. There we always
pass in the transport feedback observer.

https://codereview.webrtc.org/1674663002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream.cc:162:
congestion_controller_->GetRemoteBitrateEstimator(false),
I think we should be able to pass in nullptr here.

[pbos-webrtc, 2016-02-11 10:27:51]

rebase

[pbos-webrtc, 2016-02-11 11:23:24]

feedback + test update

[pbos-webrtc, 2016-02-11 11:23:34]

PTAL

https://codereview.webrtc.org/1674663002/diff/20001/webrtc/video/video_send_s...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/1674663002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream.cc:161: GetTransportFeedbackObserver(),
On 2016/02/11 10:15:40, stefan-webrtc (holmer) wrote:
> I'd prefer if this is done as in audio_send_stream.cc instead. There we always
> pass in the transport feedback observer.

Done.

https://codereview.webrtc.org/1674663002/diff/20001/webrtc/video/video_send_s...
webrtc/video/video_send_stream.cc:162:
congestion_controller_->GetRemoteBitrateEstimator(false),
On 2016/02/11 10:15:40, stefan-webrtc (holmer) wrote:
> I think we should be able to pass in nullptr here.

Done.

[stefan-webrtc, 2016-02-11 12:28:07]

lgtm, but see nit

https://codereview.webrtc.org/1674663002/diff/60001/webrtc/video/vie_receiver.cc
File webrtc/video/vie_receiver.cc (right):

https://codereview.webrtc.org/1674663002/diff/60001/webrtc/video/vie_receiver...
webrtc/video/vie_receiver.cc:247: RTC_DCHECK(remote_bitrate_estimator_);
Why not keep it up there to fail as early as possible?

[pbos-webrtc, 2016-02-11 12:48:13]

https://codereview.webrtc.org/1674663002/diff/60001/webrtc/video/vie_receiver.cc
File webrtc/video/vie_receiver.cc (right):

https://codereview.webrtc.org/1674663002/diff/60001/webrtc/video/vie_receiver...
webrtc/video/vie_receiver.cc:247: RTC_DCHECK(remote_bitrate_estimator_);
On 2016/02/11 12:28:06, stefan-webrtc (holmer) wrote:
> Why not keep it up there to fail as early as possible?

nullptr on the sender side, which shouldn't call DeliverRtp.

[pbos-webrtc, 2016-02-11 12:51:22]

Description was changed from

==========
Initialize VideoSendStream members in constructor.

Removes scoped_ptrs and provides clearer lifetime between objects.

BUG=webrtc:5494
R=stefan@webrtc.org
==========

to

==========
Initialize VideoSendStream members in constructor.

Removes scoped_ptrs and provides clearer lifetime between objects.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/8c66a00a377ac25d732e7c99c...
==========

[pbos-webrtc, 2016-02-11 12:51:23]

Committed patchset #4 (id:60001) manually as
8c66a00a377ac25d732e7c99c90d65b15553c304 (presubmit successful).

[commit-bot: I haz the power, 2016-02-11 12:52:31]

Description was changed from

==========
Initialize VideoSendStream members in constructor.

Removes scoped_ptrs and provides clearer lifetime between objects.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/8c66a00a377ac25d732e7c99c...
==========

to

==========
Initialize VideoSendStream members in constructor.

Removes scoped_ptrs and provides clearer lifetime between objects.

BUG=webrtc:5494
R=stefan@webrtc.org

Committed: https://crrev.com/8c66a00a377ac25d732e7c99c90d65b15553c304
Cr-Commit-Position: refs/heads/master@{#11571}
==========

[commit-bot: I haz the power, 2016-02-11 12:52:32]

Patchset 4 (id:??) landed as
https://crrev.com/8c66a00a377ac25d732e7c99c90d65b15553c304
Cr-Commit-Position: refs/heads/master@{#11571}