Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: webrtc/video/video_send_stream.h

Issue 1674663002: Initialize VideoSendStream members in constructor. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: feedback + test update Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_VIDEO_VIDEO_SEND_STREAM_H_ 11 #ifndef WEBRTC_VIDEO_VIDEO_SEND_STREAM_H_
12 #define WEBRTC_VIDEO_VIDEO_SEND_STREAM_H_ 12 #define WEBRTC_VIDEO_VIDEO_SEND_STREAM_H_
13 13
14 #include <map> 14 #include <map>
15 #include <vector> 15 #include <vector>
16 16
17 #include "webrtc/call.h" 17 #include "webrtc/call.h"
18 #include "webrtc/call/transport_adapter.h" 18 #include "webrtc/call/transport_adapter.h"
19 #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h" 19 #include "webrtc/common_video/libyuv/include/webrtc_libyuv.h"
20 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h" 20 #include "webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h"
21 #include "webrtc/video/encoded_frame_callback_adapter.h" 21 #include "webrtc/video/encoded_frame_callback_adapter.h"
22 #include "webrtc/video/encoder_state_feedback.h"
22 #include "webrtc/video/payload_router.h" 23 #include "webrtc/video/payload_router.h"
23 #include "webrtc/video/send_statistics_proxy.h" 24 #include "webrtc/video/send_statistics_proxy.h"
24 #include "webrtc/video/video_capture_input.h" 25 #include "webrtc/video/video_capture_input.h"
26 #include "webrtc/video/vie_channel.h"
27 #include "webrtc/video/vie_encoder.h"
25 #include "webrtc/video_receive_stream.h" 28 #include "webrtc/video_receive_stream.h"
26 #include "webrtc/video_send_stream.h" 29 #include "webrtc/video_send_stream.h"
27 30
28 namespace webrtc { 31 namespace webrtc {
29 32
30 class BitrateAllocator; 33 class BitrateAllocator;
31 class CallStats; 34 class CallStats;
32 class CongestionController; 35 class CongestionController;
33 class EncoderStateFeedback;
34 class ProcessThread; 36 class ProcessThread;
35 class ViEChannel; 37 class ViEChannel;
36 class ViEEncoder; 38 class ViEEncoder;
37 class VieRemb; 39 class VieRemb;
38 40
39 namespace internal { 41 namespace internal {
40 42
41 class VideoSendStream : public webrtc::VideoSendStream, 43 class VideoSendStream : public webrtc::VideoSendStream,
42 public webrtc::CpuOveruseObserver { 44 public webrtc::CpuOveruseObserver {
43 public: 45 public:
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 const VideoSendStream::Config config_; 86 const VideoSendStream::Config config_;
85 VideoEncoderConfig encoder_config_; 87 VideoEncoderConfig encoder_config_;
86 std::map<uint32_t, RtpState> suspended_ssrcs_; 88 std::map<uint32_t, RtpState> suspended_ssrcs_;
87 89
88 ProcessThread* const module_process_thread_; 90 ProcessThread* const module_process_thread_;
89 CallStats* const call_stats_; 91 CallStats* const call_stats_;
90 CongestionController* const congestion_controller_; 92 CongestionController* const congestion_controller_;
91 VieRemb* const remb_; 93 VieRemb* const remb_;
92 94
93 OveruseFrameDetector overuse_detector_; 95 OveruseFrameDetector overuse_detector_;
94 rtc::scoped_ptr<VideoCaptureInput> input_;
95 PayloadRouter payload_router_; 96 PayloadRouter payload_router_;
96 rtc::scoped_ptr<ViEEncoder> vie_encoder_; 97 ViEEncoder vie_encoder_;
97 rtc::scoped_ptr<ViEChannel> vie_channel_; 98 VideoCodingModule* const vcm_;
98 // TODO(pbos): Make proper const. 99 EncoderStateFeedback encoder_feedback_;
99 // const after construction. 100 ViEChannel vie_channel_;
100 VideoCodingModule* vcm_; 101 VideoCaptureInput input_;
101 rtc::scoped_ptr<EncoderStateFeedback> encoder_feedback_;
102
103 // Used as a workaround to indicate that we should be using the configured
104 // start bitrate initially, instead of the one reported by VideoEngine (which
105 // defaults to too high).
106 bool use_config_bitrate_;
107 }; 102 };
108 } // namespace internal 103 } // namespace internal
109 } // namespace webrtc 104 } // namespace webrtc
110 105
111 #endif // WEBRTC_VIDEO_VIDEO_SEND_STREAM_H_ 106 #endif // WEBRTC_VIDEO_VIDEO_SEND_STREAM_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698